Conversation
|
@davidsword Without giving an opinion on this PR, could you please rebase this PR on the current |
|
Rather than remove the rule, could we make it 60s instead of 900s? |
10afe5c to
ff6d85b
Compare
VIP's cron setup https://wpvip.com/blog/wordpress-cron/ https://docs.wpvip.com/wordpress-on-vip/cron-control/ Can handle frequent heavy cron schedules. Increase job frequency does not equate to slower site performance as the jobs are run async on dedicated batch containers, not front end requests.
ff6d85b to
231ea65
Compare
|
Pulled against |
jrfnl
left a comment
There was a problem hiding this comment.
Looking good ✔️
The only thing I'm wondering about is VIP-Go vs VIPMinimum.
I've just checked and the VIPMinimum ruleset includes the sniff as well and explicitly sets it to 15 minutes.
VIP-Coding-Standards/WordPressVIPMinimum/ruleset.xml
Lines 46 to 51 in ac9c5fc
Is that still correct ?
|
Yes - we've not made a start on consolidating these, so while it's not quite aligned with the ultimate end goal, it is aligned with other rules that currently exist in the initial standard. |
VIP's cron setup
https://wpvip.com/blog/wordpress-cron/
https://docs.wpvip.com/wordpress-on-vip/cron-control/
can handle frequent heavy cron schedules. On VIP increased job frequency does not equate to slower site performance as the jobs are run async on dedicated batch containers, not front end requests.