Open
Conversation
…ntation of the model. Need to adjust the offset of mesh to be in line with the base frame. Need to verify optical frame offset from base frame.
mani-monaj
requested changes
Jun 27, 2017
Member
mani-monaj
left a comment
mani-monaj
left a comment
There was a problem hiding this comment.
@atomoclast Thanks for this fix. However, can you re-factor your change such that we can load the model for Bebop1 without breaking Bebop2's TF? (e.g. through two separate files for each model + an input argument to xacro/launch file to choose the model)>
Author
|
@mani-monaj I would be glad to! I'll get back on it when I have some more bandwidth to fix it. Should be easy to do though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the Mesh file to scale correctly, adjusted the TFs to be accurate for a Bebop1.