Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates tests and test recordings for the Cognitive Language Question Answering (CQA) SDK, affecting both the runtime (question answering) and authoring packages.
Changes:
- Removed metadata filter test coverage from question answering runtime tests (both sync and async)
- Replaced source-based tests with QnA-based tests in the authoring package
- Updated test recording asset tags to reflect new test recordings
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase.py | Removed test_query_knowledgebase_filter test that validated metadata filtering functionality |
| sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase_async.py | Removed async version of test_query_knowledgebase_filter test |
| sdk/cognitivelanguage/azure-ai-language-questionanswering/assets.json | Updated test recording asset tag |
| sdk/cognitivelanguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources.py | Renamed test_add_source to test_add_chitchat and changed from testing URL source addition to QnA pair addition |
| sdk/cognitivelanguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources_async.py | Async version of the same test rename and functionality change |
| sdk/cognitivelanguage/azure-ai-language-questionanswering-authoring/assets.json | Updated test recording asset tag |
...anguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources.py
Outdated
Show resolved
Hide resolved
sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase.py
Show resolved
Hide resolved
...ognitivelanguage/azure-ai-language-questionanswering/tests/test_query_knowledgebase_async.py
Show resolved
Hide resolved
...e/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources_async.py
Outdated
Show resolved
Hide resolved
...anguage/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources.py
Outdated
Show resolved
Hide resolved
...e/azure-ai-language-questionanswering-authoring/tests/test_update_knowledge_sources_async.py
Outdated
Show resolved
Hide resolved
sarkar-rajarshi
approved these changes
Feb 5, 2026
Member
Author
|
/azp run python - cognitivelanguage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sarkar-rajarshi
approved these changes
Feb 11, 2026
Member
|
/azp run python - cognitivelanguage |
sarkar-rajarshi
approved these changes
Feb 13, 2026
|
Azure Pipelines successfully started running 1 pipeline(s). |
quentinRobinson
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines