App Config SDK/Provider Pylint Updates#45050
Merged
mrm9084 merged 11 commits intoAzure:mainfrom Feb 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses pylint version 4.0.4 compliance issues for the azure-appconfiguration and azure-appconfiguration-provider packages as part of issue #44708. The changes focus on fixing linting warnings without altering functionality.
Changes:
- Reordered imports to follow consistent pattern: stdlib, third-party, local modules, azure packages
- Added pylint disable comments for classes with many public methods
- Refactored test code to use setup methods instead of inline context managers
- Converted instance methods to static methods where appropriate
- Removed unused imports and parameters
- Fixed missing return statement in sample utility function
Reviewed changes
Copilot reviewed 55 out of 56 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| test_query_param_policy.py | Reordered imports, removed unused return statement, attempted to split long lines with multi-line strings (introduces bugs) |
| test_consistency.py | Reordered imports |
| test_azure_appconfiguration_client_async.py | Reordered imports, added pylint disable, refactored context manager usage, attempted error message line splitting (introduces bugs), added staticmethod decorator |
| test_azure_appconfiguration_client_aad_async.py | Reordered imports, added pylint disable, attempted error message line splitting (introduces bugs), split long comment |
| test_azure_appconfiguration_client_aad.py | Reordered imports, added pylint disable, attempted error message line splitting (introduces bugs) |
| test_azure_appconfiguration_client.py | Reordered imports, added pylint disable, removed unused imports, refactored context manager usage, attempted error message line splitting (introduces bugs), fixed SecretReferenceConfigurationSetting test, added staticmethod decorator |
| test_audience_policy.py | Reordered imports |
| test_audience_error_handling_live_async.py | Reordered imports, removed unused imports |
| test_audience_error_handling_live.py | Reordered imports, removed unused imports |
| preparers.py (azure-appconfiguration) | Reordered imports, attempted connection string line splitting (introduces bugs) |
| perfstress_tests/set.py | Removed unused import |
| perfstress_tests/get.py | Removed unused import |
| asynctestcase.py | Reordered imports |
| snapshot_sample_async.py | Reordered imports, split long docstring |
| snapshot_sample.py | Reordered imports, split long docstring |
| hello_world_sample_entra_id_and_bleu.py | Split long docstring, changed environment variable name (introduces documentation inconsistency) |
| hello_world_entra_id_sample.py | Changed environment variable name (introduces documentation inconsistency) |
| conditional_operation_sample.py | Fixed early return pattern |
| testcase.py (azure-appconfiguration-provider) | Reordered imports |
| test_tag_filters.py | Reordered imports, removed unused import |
| test_snapshots.py | Removed unused import |
| test_request_tracing_context.py | Added pylint disable comment (missing space) |
| test_provider_refresh.py | Reordered imports |
| test_provider_feature_management.py | Reordered imports |
| test_provider_aad.py | Reordered imports |
| test_provider.py | Reordered imports, removed unused parameter |
| test_json.py | Minor whitespace fix in test string |
| test_discovery.py | Reordered imports |
| test_configuration_client_manager_load_balance.py | Reordered imports |
| test_configuration_client_manager.py | Reordered imports |
| key_vault/test_secret_refresh.py | Reordered imports |
| key_vault/test_secret_provider.py | Reordered imports |
| aio/test_configuration_async_client_manager_load_balance.py | Reordered imports |
| aio/test_configuration_async_client_manager.py | Reordered imports, split long patch decorator paths |
| aio/test_async_snapshots.py | Removed unused import |
| aio/test_async_provider_refresh.py | Reordered imports |
| aio/test_async_provider_feature_management.py | Reordered imports |
| aio/test_async_provider_aad.py | Reordered imports |
| aio/test_async_provider.py | Reordered imports, split long comment |
| aio/test_async_discovery.py | Reordered imports, removed unused import |
| aio/key_vault/test_async_secret_refresh.py | Reordered imports, removed unused import |
| aio/key_vault/test_async_secret_provider.py | Reordered imports |
| samples/snapshot_sample.py (provider) | Removed unused import |
| samples/sample_utilities.py | Added missing return statement |
| samples/refresh_sample_feature_flags.py | Reordered imports, changed unused parameter to underscore, split long comment |
| samples/refresh_sample.py | Reordered imports, changed unused parameter to underscore, split long comment |
| samples/key_vault_reference_sample.py | Reordered imports |
| samples/key_vault_reference_customized_clients_sample.py | Reordered imports |
| samples/connection_string_sample.py | Reordered imports |
| samples/async_snapshot_sample.py | Reordered imports |
| samples/async_key_vault_reference_sample.py | Reordered imports |
| samples/async_key_vault_reference_provided_clients_sample.py | Reordered imports |
| samples/async_connection_string_sample.py | Reordered imports |
| samples/async_aad_sample.py | Reordered imports |
| samples/aad_sample.py | Reordered imports |
sdk/appconfiguration/azure-appconfiguration/samples/hello_world_entra_id_sample.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/tests/test_query_param_policy.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/tests/test_query_param_policy.py
Outdated
Show resolved
Hide resolved
...ppconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client_aad_async.py
Outdated
Show resolved
Hide resolved
...ppconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client_aad_async.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client_async.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client_async.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client_aad.py
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/azure-appconfiguration/tests/test_azure_appconfiguration_client.py
Outdated
Show resolved
Hide resolved
rossgrambo
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 1 of updates for #44708, a second PR needs to be created to update the sanitation steps.
Note: Only samples/tests have been modified as part of this change.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines