foundry agent cannot use key auth#45056
Merged
xitzhang merged 4 commits intoAzure:mainfrom Feb 11, 2026
Merged
Conversation
|
Thank you for your contribution @niuzheng168! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to enable Azure CLI credential authentication for the foundry agent sample, addressing an issue where the agent couldn't use key authentication. However, the implementation is incomplete and introduces API design inconsistencies.
Changes:
- Added imports for
AzureCliCredentialandDefaultAzureCredentialfrom azure.identity.aio - Changed the
credentialparameter type annotation to only acceptAzureCliCredentialorDefaultAzureCredential - Removed API key authentication logic and validation, hardcoding credential to
AzureCliCredential()
yulin-li
reviewed
Feb 6, 2026
xitzhang
approved these changes
Feb 6, 2026
xitzhang
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
foundry agent cannot use key auth
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines