Skip to content

foundry agent cannot use key auth#45056

Merged
xitzhang merged 4 commits intoAzure:mainfrom
niuzheng168:main
Feb 11, 2026
Merged

foundry agent cannot use key auth#45056
xitzhang merged 4 commits intoAzure:mainfrom
niuzheng168:main

Conversation

@niuzheng168
Copy link
Contributor

Description

foundry agent cannot use key auth

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@niuzheng168 niuzheng168 requested a review from rhurey as a code owner February 6, 2026 10:06
Copilot AI review requested due to automatic review settings February 6, 2026 10:06
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Voice Live labels Feb 6, 2026
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Thank you for your contribution @niuzheng168! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to enable Azure CLI credential authentication for the foundry agent sample, addressing an issue where the agent couldn't use key authentication. However, the implementation is incomplete and introduces API design inconsistencies.

Changes:

  • Added imports for AzureCliCredential and DefaultAzureCredential from azure.identity.aio
  • Changed the credential parameter type annotation to only accept AzureCliCredential or DefaultAzureCredential
  • Removed API key authentication logic and validation, hardcoding credential to AzureCliCredential()

@xitzhang xitzhang self-requested a review February 11, 2026 00:02
@xitzhang xitzhang merged commit e25274d into Azure:main Feb 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Voice Live

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants