ADFS labs were decommissioned since late July 2025#845
Conversation
tests/test_e2e.py
Outdated
| config["password"] = self.get_lab_user_secret(config["lab_name"]) | ||
| self._test_username_password(**config) | ||
|
|
||
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) |
There was a problem hiding this comment.
ADFSv2 was not decommissioned
There was a problem hiding this comment.
When running this test case, it will visit the MEX endpoint of the ADFS https://fs.msidlab4.com/adfs/services/trust/mex
That endpoint gives an http 504 error right now. If it is not decommissioned, then we will need to investigate whether it is not configured properly.
| self._test_username_password(**config) | ||
|
|
||
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) | ||
| def test_adfs2019_fed_user(self): |
There was a problem hiding this comment.
When running this test case, it will visit the MEX endpoint of the ADFS https://fs.msidlab8.com/adfs/services/trust/mex
That endpoint gives an http 504 error right now. If it is not decommissioned, then we will need to investigate whether it is not configured properly.
bgavrilMS
left a comment
bgavrilMS
left a comment
There was a problem hiding this comment.
advs 2019 and v4 were not decommissioned.
tests/test_e2e.py
Outdated
| config["password"] = self.get_lab_user_secret(config["lab_name"]) | ||
| self._test_username_password(**config) | ||
|
|
||
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) |
There was a problem hiding this comment.
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) | |
| @unittest.skip(_ADFS_TESTS) |
There was a problem hiding this comment.
@bgavrilMS and @gladjohn ,
Just to be clear. All the modified test cases are currently failing, so I have to disable them to make the build pipeline passing (or else I wouldn't be able to ship MSAL Python 1.34.0b1 last week).
@gladjohn , if your concern is only about the wording, I/we could change the message in line 844.
rayluo
force-pushed
the
adfs-labs-decommissioned
branch
from
854136a to
bebbdd4
Compare
3 participants
Disables the relevant e2e test cases