Relax ucobounds preconditions and fix ucobound defects#297
Merged
bonachea merged 7 commits intoBerkeleyLab:mainfrom Feb 26, 2026
Merged
Relax ucobounds preconditions and fix ucobound defects#297bonachea merged 7 commits intoBerkeleyLab:mainfrom
bonachea merged 7 commits intoBerkeleyLab:mainfrom
Conversation
bonachea
added
bug
* Accept ucobounds of size (corank - 1) when creating coarray descriptors If provided, the trailing ucobounds must still meet the specified invariants * Add coshape_epp to the coarray descriptor This new field holds the precomputed exclusive prefix product of the coshape. * Fix prif_ucobound to recompute the trailing ucobound based on current team size * Fix prif_coshape to properly account for the trailing ucobound * Use coshape_epp to accelerate prif_image_index and prif_initial_team_index
* Simplify the logic for the common case of corank == 1 * Remove some redundant arithmetic and branchs for the general case * Add a safety check for coshape overflow
New expected trailing ucobound values, and exercise optional trailing ucobound
bonachea
force-pushed
the
ucobounds-on-main
branch
from
41a2a95 to
2669755
Compare
Member
Author
|
CC @JDPailleux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks Caffeine's handling of ucobounds, fixing it to comply with F23
UCOBOUNDand deploying the ucobound relaxation on coarray descriptor creation proposed for PRIF 0.8.Fixes #296
Implements prif#154
See commit messages for details.