Conversation
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
its-me-abhishek
left a comment
its-me-abhishek
left a comment
There was a problem hiding this comment.
The PR looks mostly good. Although I guess this is related to #417 as well. Could you please work on that in this as well, if possible, or create another PR for that. We would probably require the isLoggedIn state to track the login state. Then redirect to homepage (/home) from landing page, if the user is already logged in
| import { url } from '@/components/utils/URLs'; | ||
|
|
||
| export const Footer = () => { | ||
| const handleLogoClick = (e: React.MouseEvent<HTMLAnchorElement>) => { |
There was a problem hiding this comment.
this function is being re used, would make sense to extract this out into utils
|
@greedy-wudpeckr please do add tests for the same as well, inside the relevant dirs. Also the PR name should be more descriptive (can be done later on depending on the above suggestions) |
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
Signed-off-by: greedy-wudpeckr <mudituiet@gmail.com>
|
PTAL @its-me-abhishek |
2 participants
Description
Prevent navbar logo from redirecting to landing page when logged in
Changed logo click behavior to refresh page instead of navigating to /
Prevents logged-in users from being redirected to landing page
Maintains better UX by keeping users on their current page"
Fixes: Bug : Redirects to landing page even if we are logged in. #445
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
cc.mov