Skip to content

Update cqgi for py3.14#1986

Merged
adam-urbanczyk merged 2 commits intomasterfrom
cqgi-fix
Feb 10, 2026
Merged

Update cqgi for py3.14#1986
adam-urbanczyk merged 2 commits intomasterfrom
cqgi-fix

Conversation

@adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Feb 7, 2026

This fixes cqgi for 3.14. Let's merge it before 2.7.

@adam-urbanczyk adam-urbanczyk mentioned this pull request Feb 7, 2026
9 tasks
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.17%. Comparing base (0cccbe4) to head (8c84c57).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cadquery/cqgi.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
+ Coverage   95.96%   96.17%   +0.20%     
==========================================
  Files          29       29              
  Lines        7964     8087     +123     
  Branches     1194     1213      +19     
==========================================
+ Hits         7643     7778     +135     
+ Misses        184      178       -6     
+ Partials      137      131       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmwright
Copy link
Member

jmwright commented Feb 9, 2026

Thanks @adam-urbanczyk

The only thing I noticed is the deprecation below for Python 3.14. I'm wondering if it is worth fixing it in this PR so that we do not have to come back to it later. I think it may be a little tricky though because you may have to support both forms to keep from breaking earlier Python versions.

tests/test_cqgi.py::TestCQGI::test_build_with_debug
  /home/jwright/repos/cadquery/cadquery/cqgi.py:559: DeprecationWarning: ast.NameConstant is deprecated and will be removed in Python 3.14; use ast.Constant instead
    if hasattr(ast, "NameConstant"):

@adam-urbanczyk
Copy link
Member Author

Agreed @jmwright ! I think I fixed everything, but it seems that GH is having issues today.

@jmwright jmwright self-requested a review February 9, 2026 20:00
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk

I went ahead and approved this PR for when GitHub starts behaving again.

@adam-urbanczyk adam-urbanczyk merged commit 6cd5eeb into master Feb 10, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments