Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
==========================================
+ Coverage 95.96% 96.17% +0.20%
==========================================
Files 29 29
Lines 7964 8087 +123
Branches 1194 1213 +19
==========================================
+ Hits 7643 7778 +135
+ Misses 184 178 -6
+ Partials 137 131 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @adam-urbanczyk The only thing I noticed is the deprecation below for Python 3.14. I'm wondering if it is worth fixing it in this PR so that we do not have to come back to it later. I think it may be a little tricky though because you may have to support both forms to keep from breaking earlier Python versions. tests/test_cqgi.py::TestCQGI::test_build_with_debug
/home/jwright/repos/cadquery/cadquery/cqgi.py:559: DeprecationWarning: ast.NameConstant is deprecated and will be removed in Python 3.14; use ast.Constant instead
if hasattr(ast, "NameConstant"): |
|
Agreed @jmwright ! I think I fixed everything, but it seems that GH is having issues today. |
jmwright
left a comment
There was a problem hiding this comment.
Thanks @adam-urbanczyk
I went ahead and approved this PR for when GitHub starts behaving again.
This fixes cqgi for 3.14. Let's merge it before 2.7.