fix: use minio/minio instead of bitnami/minio#1444
fix: use minio/minio instead of bitnami/minio#1444yeskunall wants to merge 2 commits intoCapSoftware:mainfrom
minio/minio instead of bitnami/minio#1444Conversation
WalkthroughSwitches the Docker Compose MinIO service from Bitnami to the official MinIO image, adds a command to run the server on Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docker-compose.template.yml(2 hunks)
🔇 Additional comments (2)
docker-compose.template.yml (2)
48-48: Good catch on the typo fix.The comment correction from "Local S3 Strorage" to "Local S3 Storage" is appreciated.
53-65: Port and volume configuration is correct.The exposed ports (3902 for API, 3903 for console) and volume mount path (
/datainstead of/bitnami/minio/data) are appropriate for the official MinIO image. The command arguments properly configure the API and console server addresses.
|
Awesome! Can you check the coderabbit comments and see if they are applicable? |
|
@richiemcilroy they are! I forgot to yeet those env vars. Can you confirm if things look good now? |
Bitnami deprecated
bitnami/minioearlier this year in August. Simply switching to useminio/miniodidn’t work, however. LMK if there’s anything I need to do to get this merged.💖
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.