[Rebase] [ENG-9177] Removed ember#11531
[Rebase] [ENG-9177] Removed ember#11531adlius merged 9 commits intoCenterForOpenScience:feature/pbs-26-2from
Conversation
Vlad0n20
left a comment
Vlad0n20
left a comment
There was a problem hiding this comment.
LGTM!
There is one point with tests
|
|
||
| def test_get_user_by_external_info(self): | ||
| service_url = 'http://localhost:5000/dashboard/' | ||
| service_url = 'http://localhost:5000/my_projects/' |
There was a problem hiding this comment.
Test assertions use /my_projects/ but actual route is /myprojects/
|
@antkryt There are some merge conflicts that needs taken care of. |
adlius
left a comment
adlius
left a comment
There was a problem hiding this comment.
Some small questions. Overall looks good.
website/project/views/drafts.py
Outdated
| @must_be_contributor_and_not_group_member | ||
| @ember_flag_is_active(features.EMBER_EDIT_DRAFT_REGISTRATION) | ||
| @must_be_branched_from_node | ||
| def edit_draft_registration_page(auth, node, draft, **kwargs): |
There was a problem hiding this comment.
Maybe this view is no longer needed?
There was a problem hiding this comment.
Used only for legacy server-side rendered pages. Removed
website/project/views/drafts.py
Outdated
| @must_be_valid_project | ||
| @must_be_contributor_and_not_group_member | ||
| @ember_flag_is_active(features.EMBER_CREATE_DRAFT_REGISTRATION) | ||
| def new_draft_registration(auth, node, *args, **kwargs): |
There was a problem hiding this comment.
Is this view still needed?
There was a problem hiding this comment.
Used only for legacy server-side rendered pages. Removed
| @must_be_logged_in | ||
| @must_have_permission(READ) | ||
| @ember_flag_is_active(features.EMBER_PROJECT_SETTINGS) | ||
| def node_setting(auth, node, **kwargs): |
There was a problem hiding this comment.
Is this view still needed?
There was a problem hiding this comment.
Some addons (GitHub, GitLab, Bitbucket) use node.web_url_for('node_setting') to direct users back to the legacy settings page. I'm not sure it's safe to delete
adlius
merged commit 62f5813
into
CenterForOpenScience:feature/pbs-26-2
4 participants
Purpose
Original PR was rebased and contains unrelated commits.
This PR reconstructs the intended changes by cherry-picking the last 6 commits only.
Changes
QA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9177