Open
Conversation
dburkhart07
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #139
📝 Description
For this PR, I moved all volunteer related logic into its own separate module. I did not create a new entity for this, but I did create new controlleres, modules, and services).
I also chose to write the volunteer tests, since it has likely not been made into a ticket (if it has been I'm sorry). This brought up a realization that I messed up the setup and takedown of the test database, however, and implemented that fix in the PR. This made it so that, the database is reset back to nothing after each test, which was not properly occuring previously. Since we are interacting with a database, I also made it so that tests run sequentially now, as we will have issues altering the database in multiple ways simultaneously.
✔️ Verification
Verified all tests pass, and all new endpoints in volunteers work properly in Postman.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!