Support showing ctrl, alt, win keys pressed down without any other key#160
Support showing ctrl, alt, win keys pressed down without any other key#160bfritscher wants to merge 3 commits intoCode52:masterfrom
Conversation
- Removed filtering of modifierkey to allow to handle them in ToInputs. - Filtered triggering of modifier display for modifierkeys themselves in ToInputs. - Exposed IsModifierKeyPress as static to be used in KeyPress and Messages. - KeyPress.HasModifierPress returns false if key is a modifierkey itself (allow the merging in Message). - Removed merge flag in favor of handling the strategy directly in Message.MergeIfNeeded
ec1cd25 to
c3e04a8
Compare
|
after integrating it with my other changes i found there are bugs, and found another solution, but it now seems to fail the tests :-( But a side effect is that it now support issue #76 |
|
Hey @bfritscher, I haven't forgotten about your PRs, I've just been busy with some other things lately. I should have some time over the next week or so to sit down and review your PRs. My apologies for the delay in getting to them! Thanks, |
|
@alfhenrik No problems :-) |
|
To solve this issue would be so helpful, to show CTRL SHIFT stand alone. Any progress maybe? |
|
I was looking to get a counter on the modifier keys specifically, but there seems no option to do so... |
Hi, @bfritscher I really appreciate your work to add the mouse highlight, but the https://github.com/bfritscher/carnac/tree/v3-beta seem have a bug, like #173 descripe, when hold two keys and left click, but it dosen't show any key just the mouse icon. |
|
Any possibility of getting this merged? |
ToInputs.
Messages.
(allow the merging in Message).
themself, but still handling their repeat, in order for them to keep
showing while keydown.
This should partially solve issue #154
Note sure about the sticky key part on mac.