London | 25-SDC-Nov | Emiliano Uruena | Sprint 2 | Improve with caches#140
Open
Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | 25-SDC-Nov | Emiliano Uruena | Sprint 2 | Improve with caches#140Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Emilianouz
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Emilianouz
changed the title
This comment has been minimized.
This comment has been minimized.
Refactored fibonacci function to use a cache for improved performance.
Emilianouz
changed the title
Emilianouz
added
the
Needs Review
cjyuan
reviewed
Mar 2, 2026
cjyuan
added
Reviewed
Add a count variable to track coin multiples in the change calculation.
Emilianouz
added
Needs Review
cjyuan
reviewed
Mar 2, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good. Well done.
Note: Unrelated to cache, but we could further improve the performance by computing the number of ways in one operation when there is only one coin left to consider.
Comment on lines
+33
to
+39
| count = 1 | ||
| while coin * count <= total: | ||
| ways += ways_to_make_change_helper(total - coin * count, coins, coin_index + 1, cache) | ||
| count += 1 | ||
|
|
||
| # counting combinations that don't use the current coin | ||
| ways += ways_to_make_change_helper(total, coins, coin_index + 1, cache) |
There was a problem hiding this comment.
Line 39 is line 35 when count is 0.
Could probably save a few lines of code.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Optimize Fibonacci and Making Change functions with caching for improved performance