London | SDC Nov 25 | Emiliano Uruena | Sprint 2 |Improve with precomputing#142
Open
Emilianouz wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
London | SDC Nov 25 | Emiliano Uruena | Sprint 2 |Improve with precomputing#142Emilianouz wants to merge 2 commits intoCodeYourFuture:mainfrom
Emilianouz wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Emilianouz
added
the
Needs Review
cjyuan
reviewed
Mar 2, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you use complexity to explain how the new implementation are better than the original implementation?
Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py
Outdated
Show resolved
Hide resolved
cjyuan
added
Reviewed
using sorted(strings) to prevent the side effect.
Emilianouz
added
Needs Review
|
Can you also address this comment: #142 (review) |
cjyuan
added
Reviewed
Author
@cjyuan The original had complexity O(n² × m) because compares every possible pair of strings, and each comparison can take up to O(string length). The improved version first sorts the list in O(n log n) then only compares neighbours strings O(n × m). That reduces the number of comparisons. |
Emilianouz
added
Needs Review
|
If we are factoring in the length of the strings, m, then the complexity of sorting won't just be O(nlogn). nlogn measures only the number of comparisons needed. |
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Refactor common_prefix and count_letter functions with precomputing.