Skip to content

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Form-Controls #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Darkidd77 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Form-Controls #1106

Darkidd77 wants to merge 6 commits into from
+51 −13

Conversation

@Darkidd77
Copy link

@Darkidd77 Darkidd77 commented Jan 31, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added name validation: Added minlength="2" to ensure names are at least 2 characters long.
  • Fixed size options: to meet the 6-size requirement (XS, S, M, L, XL, XXL).
  • Made colour selection required.
  • Added submit button.

@netlify
Copy link

netlify bot commented Jan 31, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e8be45a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697f8c7531f076000834f9ff
😎 Deploy Preview https://deploy-preview-1106--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@Darkidd77 Darkidd77 marked this pull request as ready for review February 1, 2026 17:35
@github-actions

This comment has been minimized.

Sign in to view
@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@Darkidd77 Darkidd77 changed the title Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 1 | Form-Controls Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Form-Controls Feb 1, 2026
@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Darkidd77