generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 418
Sheffield | 26-ITP-JAN | Grant Riches | Sprint 2 | Form Controls #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grantriches-byte
wants to merge
14
commits into
CodeYourFuture:main
Choose a base branch
from
grantriches-byte:form-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−25
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0b5f732
Add README article content and improve page header and footer
grantriches-byte fb2587f
Add all three articles with semantic HTML and descriptive content
grantriches-byte 1288ec1
I have changed the grid layout and fixed the footer to bottm of viewp…
grantriches-byte dff033c
Footer centralised
grantriches-byte 89bdacc
Header background changed, Buttons added for Read Me links, article b…
grantriches-byte d4c4bd4
Made button positions uniformed.
grantriches-byte bdb588a
Form controls updated
grantriches-byte 2c1fe0a
Merge branch 'CodeYourFuture:main' into form-control
grantriches-byte 9593e20
Removed wireframe css from form control branch
grantriches-byte 56f4109
updated work
grantriches-byte c73c65e
Merge branch 'form-control' of https://github.com/grantriches-byte/Mo…
grantriches-byte a74fe90
name added at the bottom
grantriches-byte 72f6a4f
Revert changes in Wireframe
grantriches-byte eb13c85
Revert changes in Wireframe
grantriches-byte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,87 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>T-Shirt Order Form</title> | ||
| </head> | ||
| <body> | ||
|
|
||
| <main> | ||
| <h1>Order Your T-Shirt</h1> | ||
|
|
||
| <form> | ||
|
|
||
| <!-- Customer Details --> | ||
| <fieldset> | ||
| <legend>Customer Details</legend> | ||
|
|
||
| <p> | ||
| <label for="name">Name:</label><br> | ||
| <input type="text" id="name" name="name" required minlength="2"> | ||
| </p> | ||
|
|
||
| <p> | ||
| <label for="email">Email:</label><br> | ||
| <input type="email" id="email" name="email" required> | ||
| </p> | ||
|
|
||
| </fieldset> | ||
|
|
||
| <!-- T-Shirt Colour --> | ||
| <fieldset> | ||
| <legend>T-Shirt Colour</legend> | ||
|
|
||
| <p>Please choose a colour:</p> | ||
|
|
||
| <p> | ||
| <label> | ||
| <input type="radio" name="colour" value="red" required> | ||
| Red | ||
| </label> | ||
| </p> | ||
|
|
||
| <p> | ||
| <label> | ||
| <input type="radio" name="colour" value="blue"> | ||
| Blue | ||
| </label> | ||
| </p> | ||
|
|
||
| <p> | ||
| <label> | ||
| <input type="radio" name="colour" value="green"> | ||
| Green | ||
| </label> | ||
| </p> | ||
|
|
||
| </fieldset> | ||
|
|
||
| <!-- T-Shirt Size --> | ||
| <fieldset> | ||
| <legend>T-Shirt Size</legend> | ||
|
|
||
| <p> | ||
| <label for="size">Choose a size:</label><br> | ||
| <select id="size" name="size" required> | ||
| <option value="">--Please choose an option--</option> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> | ||
| </p> | ||
|
|
||
| </fieldset> | ||
|
|
||
| <!-- Submit Button --> | ||
| <p> | ||
| <button type="submit">Submit</button> | ||
| </p> | ||
|
|
||
| <p>BY Grant Riches</p> | ||
|
|
||
|
|
||
| <!DOCTYPE html> | ||
|
Comment on lines
+5
to
+87
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, double check the tags (ending tags, to be more precise), it looks like the ending of the file got overwritten with the beginning. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you doublecheck the end tag of the form?