Remove Reflection*::setAccessible() calls + drop PHP < 8.1#53
Remove Reflection*::setAccessible() calls + drop PHP < 8.1#53SamMousa merged 2 commits intoCodeception:masterfrom
Conversation
|
CI failure will be fixed in #52 |
3dcb2ed to
5ac8021
Compare
|
@SamMousa Rebase done - thank you! |
|
I cannot casually merge a PHP version bump though... So this will require a major release. |
I noticed that for Codeception itself a PHP version bump was done in a minor release ( https://github.com/Codeception/Codeception/releases/tag/5.3.0 ). But I'm okay if you prefer to not bump the PHP version in a minor/patch release. I could rework this PR to only call |
Fair enough, a minor release it is then! We don't have a very big group (or well organised group) of maintainers. I'll merge this, then I'll try and figure out how we do releases for this repo. |
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
(https://www.php.net/manual/en/reflectionmethod.setaccessible.php and https://www.php.net/manual/en/reflectionproperty.setaccessible.php).
There're even plans to deprecate the method in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations
This PR drops support for PHP < 8.1.
Thus, the calls can be safely removed.