Add <Activity> #3949
Open
Add <Activity> #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
commented
Feb 6, 2026
| const [blockSize, setBlockSize] = useState(1); | ||
| const [horizontalScrollbarHeight, setHorizontalScrollbarHeight] = useState(0); | ||
| const [isMeasured, setIsMeasured] = useState(false); | ||
| const [isVisible, setIsVisible] = useState(true); |
Collaborator
Author
There was a problem hiding this comment.
Tests break if I do not leave this initial state as true.
Should be fine once we move all our tests to use locators instead.
| const { ResizeObserver } = window; | ||
| const { ResizeObserver, IntersectionObserver } = window; | ||
|
|
||
| // don't break in Node.js (SSR), jsdom, and browsers that don't support ResizeObserver |
Collaborator
Author
There was a problem hiding this comment.
SSR environments do not run useLayoutEffect, not sure that part of the comment was ever applicable.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3949 +/- ##
==========================================
+ Coverage 97.61% 97.71% +0.09%
==========================================
Files 36 36
Lines 1470 1486 +16
Branches 477 478 +1
==========================================
+ Hits 1435 1452 +17
+ Misses 35 34 -1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if we used
<Activity>to passively render the grid's content when it's not visible, or not yet measured?https://react.dev/reference/react/Activity
Worth it? Not worth bothering? Just wanted to play with it at least.
We could also add a prop to let users pass their own
modeto<Activity>.