Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,16 @@
}
}
},
{
"includes": ["test/failOnConsole.ts"],
"linter": {
"rules": {
"suspicious": {
"noConsole": "off"
}
}
}
},
{
"includes": ["**/*.js", "**/rolldown.config.ts"],
"linter": {
Expand Down
14 changes: 12 additions & 2 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,8 @@ export default defineConfig([
'vitest/no-disabled-tests': 0,
'vitest/no-done-callback': 1,
'vitest/no-duplicate-hooks': 1,
'vitest/no-focused-tests': 1,
'vitest/no-hooks': 1,
'vitest/no-focused-tests': [1, { fixable: false }],
'vitest/no-hooks': 0,
'vitest/no-identical-title': 1,
'vitest/no-import-node-test': 1,
'vitest/no-importing-vitest-globals': 1,
Expand Down Expand Up @@ -741,6 +741,16 @@ export default defineConfig([
}
},

{
name: 'tools',

files: ['test/failOnConsole.ts'],

rules: {
'no-console': 0
}
},

{
name: 'node',

Expand Down
38 changes: 38 additions & 0 deletions test/failOnConsole.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
let consoleErrorOrConsoleWarnWereCalled = false;

beforeAll(() => {
// replace instead of mutating `console` to avoid infinite loops
globalThis.console = {
...console,
error(...params) {
if (
params[0] instanceof Error &&
params[0].message === 'ResizeObserver loop completed with undelivered notifications.'
) {
return;
}

consoleErrorOrConsoleWarnWereCalled = true;
console.log(...params);
},
warn(...params) {
consoleErrorOrConsoleWarnWereCalled = true;
console.log(...params);
}
};
});

afterEach(() => {
if (!consoleErrorOrConsoleWarnWereCalled) {
return;
}

consoleErrorOrConsoleWarnWereCalled = false;

// Errors thrown in `afterEach` will short-circuit subsequent `afterEach` hooks,
// thus preventing tests from being cleaned up properly and affecting other tests.
// We must therefore wait for tests to "finish" before throwing the error.
onTestFinished(() => {
throw new Error('console.error() and/or console.warn() were called during the test');
});
});
8 changes: 5 additions & 3 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export default defineConfig(
test: {
dir: 'test',
globals: true,
printConsoleTrace: true,
coverage: {
provider: 'istanbul',
enabled: isCI,
Expand Down Expand Up @@ -156,7 +157,7 @@ export default defineConfig(
headless: true,
screenshotFailures: !isCI
},
setupFiles: ['test/setupBrowser.ts']
setupFiles: ['test/setupBrowser.ts', 'test/failOnConsole.ts']
}
},
{
Expand All @@ -171,15 +172,16 @@ export default defineConfig(
headless: true,
screenshotFailures: false
},
setupFiles: ['test/setupBrowser.ts']
setupFiles: ['test/setupBrowser.ts', 'test/failOnConsole.ts']
}
},
{
extends: true,
test: {
name: 'node',
include: ['node/**/*.test.*'],
environment: 'node'
environment: 'node',
setupFiles: ['test/failOnConsole.ts']
}
}
]
Expand Down