Skip to content

Migrate from prettier to oxfmt#3960

Merged
nstepien merged 4 commits intomainfrom
oxfmt
Feb 17, 2026
Merged

Migrate from prettier to oxfmt#3960
nstepien merged 4 commits intomainfrom
oxfmt

Conversation

@nstepien nstepien self-assigned this Feb 16, 2026
@nstepien nstepien marked this pull request as ready for review February 16, 2026 20:54
Copy link
Collaborator

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It saves us 2s in CI, do you think it is worth updating?

@@ -1,5 +1,4 @@
import { css } from 'ecij';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding a space not supported?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, I just learned how to do it, so most files haven't actually changed now!

@nstepien
Copy link
Collaborator Author

It saves us 2s in CI, do you think it is worth updating?

I tried migrating to oxfmt to see if it was worthwhile/ready.
While it does a few limitations right now, I'm sure they will be resolved eventually, or they may be handled by oxlint.
It only saves 2s in the RDG CI, but I'm sure it'll have more of an impact in bigger repos.
RDG is just a good test bed for this.
Faster tools (formatting, linting, typechecking, ...) is also important to speed up the feedback loop of agents.

I think it's worth it.

Copy link
Collaborator

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nstepien nstepien merged commit 4da9ad7 into main Feb 17, 2026
2 checks passed
@nstepien nstepien deleted the oxfmt branch February 17, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants