Made dev compose file so u don't have to rebuild everytime you make changes#77
Open
tmcnulty387 wants to merge 1 commit intoComputerScienceHouse:mainfrom
Open
Made dev compose file so u don't have to rebuild everytime you make changes#77tmcnulty387 wants to merge 1 commit intoComputerScienceHouse:mainfrom
tmcnulty387 wants to merge 1 commit intoComputerScienceHouse:mainfrom
Conversation
Member
Author
|
Fixes #76 |
Member
Author
|
I'll add the other commits in a different PR, force push was a reset hard to docker compose commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hanges
What
Added
docker-compose.dev.yamlto run the vote container during developmentWhy
So you don't have to rebuild the container when you change code during development
Test Plan
Just changed the docker compose file and README, didn't run Go tests. I verified that it actually works by adding print statements in main, output does change when rerunning
podman compose -f docker-compose.dev.yaml upEnv Vars
Didn't change, just copied existing compose file and added this
Checklist