fix(auth): prevent infinite refresh loop on invalid auth token#7310
Merged
davidecavaliere merged 5 commits intonewarchitecturefrom Feb 25, 2026
Merged
fix(auth): prevent infinite refresh loop on invalid auth token#7310davidecavaliere merged 5 commits intonewarchitecturefrom
davidecavaliere merged 5 commits intonewarchitecturefrom
Conversation
- Show user-friendly "Session Expired" dialog instead of silently reloading - Fix GET /logout to properly clear session (was only redirecting) - Save URL hash before logout so users return to same page after re-login - Add flag to prevent multiple session expired dialogs from concurrent requests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Cookiezaurs
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/logoutto properly clear session (previously only redirected without clearing)Problem
When auth token was manually deleted or became invalid, the frontend would enter an infinite refresh loop. This was caused by:
CountlyHelpers.logout()callingwindow.location.reload()Solution
logout()to redirect to/logoutendpoint instead of reloading/logoutroute to callmembersUtility.logout()to properly clear sessionTest plan
🤖 Generated with Claude Code