Add ShangMi (SM2/SM3/SM4/SM9) algorithm families#812
Conversation
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
|
Hi @bhess — if you have time, would you mind taking a look at this one as well? This adds ShangMi (SM2/SM3/SM4/SM9) families and updates the schema enum. Thanks a lot — always appreciate your feedback. |
|
cc: @bhess |
bhess
left a comment
There was a problem hiding this comment.
Thanks @Mehrn0ush for the additions! See the comments inline.
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
|
One question on SM2 naming conventions for the registry: I currently model SM2 as SM2-256 (and ...-256 for ENC/KEX) to be explicit about the common curve size. Would you prefer making the suffix optional (SM2[-256]) to align with the registry’s broader matching style, or keeping it strict as SM2-256? I can adjust either way — just want to follow the convention you think is best for downstream matching. Thanks again @bhess |
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
|
Made SM2’s -256 suffix optional to accept both SM2 and SM2-256, following the registry’s [] convention. Updated patterns accordingly. |
bhess
left a comment
There was a problem hiding this comment.
Thanks for the updates, LGTM!
Fixes #811
Adds SM2/SM3/SM4/SM9 algorithm families to the CycloneDX cryptography registry and updates algorithmFamiliesEnum accordingly.
Note: some official ShangMi specification mirrors appear region-blocked or unreliable from multiple locations.
To avoid fragile links in the registry, this PR relies on globally accessible references (RFC Editor + ISO)