fix: RucioFileCatalogClient.setMetadata returns empty result on success#8467
Merged
aldbr merged 1 commit intoDIRACGrid:integrationfrom Feb 23, 2026
Merged
fix: RucioFileCatalogClient.setMetadata returns empty result on success#8467aldbr merged 1 commit intoDIRACGrid:integrationfrom
aldbr merged 1 commit intoDIRACGrid:integrationfrom
Conversation
cserf
force-pushed
the
Fix_setmetadata
branch
from
7234c12 to
a9a8adb
Compare
aldbr
reviewed
Feb 23, 2026
| return S_ERROR(str(err)) | ||
| try: | ||
| self.client.set_dids_metadata_bulk(dids=dids, recursive=False) | ||
| resDict["Successful"] = {path: True for path in paths} |
Contributor
There was a problem hiding this comment.
Just wondering, I am not familiar with Rucio: can't we have partially successful/failed operation? Seems like it can only be all successful or failed.
Author
There was a problem hiding this comment.
It's a bulk method, so either everything succeeds or fails
aldbr
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*FileCatalog
FIX: RucioFileCatalogClient.setMetadata returns empty result on success #8330
ENDRELEASENOTES