Update monitoring_ui.go: fix metric format #3111
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix metric format
agvol
changed the title
Member
|
Can you clarify why adding commas is necessary? |
Contributor
Author
https://github.com/prometheus/OpenMetrics/blob/main/specification/OpenMetrics.md#abnf also, some scrapers got error, I check vmagent and telegraf |
There was a problem hiding this comment.
Pull request overview
Fixes the Prometheus text exposition format for the dnscrypt_proxy_build_info metric by correcting the label set syntax.
Changes:
- Add missing commas between labels in the
dnscrypt_proxy_build_info{...}metric output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix metric format