Open
Conversation
WalkthroughThis PR adds Visual Studio 2026 support to the MPC build system by introducing CI workflow matrix entries, configuration files, Perl modules for project and workspace creation, and template files for various project types. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
templates/vs2026platforms.mpt (1)
12-14: Consider adding explicit settings for Win32 platform.The Win32 platform block only defines
output_subdir, while other platforms (x64, ARM, ARM64) also includecpu_defines,platform_defines,TargetMachine, andlink_options. This may be intentional if Win32 defaults are handled elsewhere, but for consistency you might consider adding explicit values:Suggested enhancement for Win32 platform block
Win32 { output_subdir = I386 + cpu_defines = _X86_ + platform_defines = WIN32 + TargetMachine = "0" // We let VC++ figure it out for us. + link_options = /machine:X86 }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/vs2026platforms.mpt` around lines 12 - 14, The Win32 platform block currently only sets output_subdir = I386; update the Win32 block (symbol: Win32) to explicitly include the same platform settings used for other platforms: add cpu_defines, platform_defines, TargetMachine, and link_options entries (matching the style/values used for x64/ARM/ARM64) so the configuration is consistent rather than relying on implicit defaults; ensure names match existing keys (cpu_defines, platform_defines, TargetMachine, link_options) and values are appropriate for 32-bit Win32.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@templates/vs2026platforms.mpt`:
- Around line 12-14: The Win32 platform block currently only sets output_subdir
= I386; update the Win32 block (symbol: Win32) to explicitly include the same
platform settings used for other platforms: add cpu_defines, platform_defines,
TargetMachine, and link_options entries (matching the style/values used for
x64/ARM/ARM64) so the configuration is consistent rather than relying on
implicit defaults; ensure names match existing keys (cpu_defines,
platform_defines, TargetMachine, link_options) and values are appropriate for
32-bit Win32.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.github/workflows/cmake.yml.github/workflows/windows.ymlconfig/wireshark.mpbdocs/USAGEdocs/html/MakeProjectCreator.htmlmodules/VS2026ProjectCreator.pmmodules/VS2026WorkspaceCreator.pmregistry.pltemplates/vs2026dll.mpttemplates/vs2026exe.mpttemplates/vs2026lib.mpttemplates/vs2026libexe.mpttemplates/vs2026platforms.mpt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes