Handle HTTP/2 status for netty server spans#10407
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
|
Bits AI Dev Agent Status: ✅ Done [Fix CI Errors] [View Dev Agent Session] You can ask for changes by mentioning @DataDog in a comment. |
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094239
Total [baseline] (10.893 s) : 0, 10893346
Agent [candidate] (1.088 s) : 0, 1087555
Total [candidate] (10.912 s) : 0, 10912440
section appsec
Agent [baseline] (1.275 s) : 0, 1275491
Total [baseline] (11.123 s) : 0, 11122531
Agent [candidate] (1.267 s) : 0, 1267156
Total [candidate] (10.985 s) : 0, 10985117
section iast
Agent [baseline] (1.227 s) : 0, 1226836
Total [baseline] (11.208 s) : 0, 11207691
Agent [candidate] (1.236 s) : 0, 1236193
Total [candidate] (11.273 s) : 0, 11272874
section profiling
Agent [baseline] (1.206 s) : 0, 1205559
Total [baseline] (10.843 s) : 0, 10842737
Agent [candidate] (1.214 s) : 0, 1213911
Total [candidate] (10.884 s) : 0, 10883880
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (657.07 ms) : 0, 657070
BytebuddyAgent [candidate] (653.456 ms) : 0, 653456
GlobalTracer [baseline] (284.983 ms) : 0, 284983
GlobalTracer [candidate] (283.345 ms) : 0, 283345
AppSec [baseline] (32.913 ms) : 0, 32913
AppSec [candidate] (32.674 ms) : 0, 32674
Debugger [baseline] (68.705 ms) : 0, 68705
Debugger [candidate] (67.873 ms) : 0, 67873
Remote Config [baseline] (658.11 µs) : 0, 658
Remote Config [candidate] (642.004 µs) : 0, 642
Telemetry [baseline] (9.048 ms) : 0, 9048
Telemetry [candidate] (8.933 ms) : 0, 8933
Flare Poller [baseline] (3.855 ms) : 0, 3855
Flare Poller [candidate] (3.82 ms) : 0, 3820
section appsec
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (696.2 ms) : 0, 696200
BytebuddyAgent [candidate] (692.51 ms) : 0, 692510
GlobalTracer [baseline] (261.038 ms) : 0, 261038
GlobalTracer [candidate] (258.953 ms) : 0, 258953
IAST [baseline] (24.923 ms) : 0, 24923
IAST [candidate] (24.648 ms) : 0, 24648
AppSec [baseline] (175.168 ms) : 0, 175168
AppSec [candidate] (174.722 ms) : 0, 174722
Debugger [baseline] (67.443 ms) : 0, 67443
Debugger [candidate] (65.877 ms) : 0, 65877
Remote Config [baseline] (737.526 µs) : 0, 738
Remote Config [candidate] (778.214 µs) : 0, 778
Telemetry [baseline] (9.37 ms) : 0, 9370
Telemetry [candidate] (9.309 ms) : 0, 9309
Flare Poller [baseline] (3.762 ms) : 0, 3762
Flare Poller [candidate] (3.68 ms) : 0, 3680
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (792.789 ms) : 0, 792789
BytebuddyAgent [candidate] (800.088 ms) : 0, 800088
GlobalTracer [baseline] (256.594 ms) : 0, 256594
GlobalTracer [candidate] (258.25 ms) : 0, 258250
IAST [baseline] (26.921 ms) : 0, 26921
IAST [candidate] (27.3 ms) : 0, 27300
AppSec [baseline] (33.097 ms) : 0, 33097
AppSec [candidate] (34.29 ms) : 0, 34290
Debugger [baseline] (68.121 ms) : 0, 68121
Debugger [candidate] (66.823 ms) : 0, 66823
Remote Config [baseline] (582.02 µs) : 0, 582
Remote Config [candidate] (560.253 µs) : 0, 560
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (8.506 ms) : 0, 8506
Flare Poller [baseline] (3.577 ms) : 0, 3577
Flare Poller [candidate] (3.534 ms) : 0, 3534
section profiling
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (701.919 ms) : 0, 701919
BytebuddyAgent [candidate] (707.504 ms) : 0, 707504
GlobalTracer [baseline] (221.264 ms) : 0, 221264
GlobalTracer [candidate] (222.835 ms) : 0, 222835
AppSec [baseline] (32.221 ms) : 0, 32221
AppSec [candidate] (32.627 ms) : 0, 32627
Debugger [baseline] (68.486 ms) : 0, 68486
Debugger [candidate] (68.827 ms) : 0, 68827
Remote Config [baseline] (663.375 µs) : 0, 663
Remote Config [candidate] (657.796 µs) : 0, 658
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (9.007 ms) : 0, 9007
Flare Poller [baseline] (3.719 ms) : 0, 3719
Flare Poller [candidate] (3.828 ms) : 0, 3828
ProfilingAgent [baseline] (97.483 ms) : 0, 97483
ProfilingAgent [candidate] (97.038 ms) : 0, 97038
Profiling [baseline] (98.057 ms) : 0, 98057
Profiling [candidate] (97.63 ms) : 0, 97630
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087236
Total [baseline] (8.837 s) : 0, 8836884
Agent [candidate] (1.087 s) : 0, 1086868
Total [candidate] (8.773 s) : 0, 8772960
section iast
Agent [baseline] (1.226 s) : 0, 1225915
Total [baseline] (9.363 s) : 0, 9362620
Agent [candidate] (1.251 s) : 0, 1250715
Total [candidate] (9.45 s) : 0, 9450449
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (651.705 ms) : 0, 651705
BytebuddyAgent [candidate] (653.341 ms) : 0, 653341
GlobalTracer [baseline] (284.32 ms) : 0, 284320
GlobalTracer [candidate] (283.813 ms) : 0, 283813
AppSec [baseline] (32.916 ms) : 0, 32916
AppSec [candidate] (32.664 ms) : 0, 32664
Debugger [baseline] (67.899 ms) : 0, 67899
Debugger [candidate] (66.792 ms) : 0, 66792
Remote Config [baseline] (640.842 µs) : 0, 641
Remote Config [candidate] (637.243 µs) : 0, 637
Telemetry [baseline] (9.026 ms) : 0, 9026
Telemetry [candidate] (9.039 ms) : 0, 9039
Flare Poller [baseline] (3.879 ms) : 0, 3879
Flare Poller [candidate] (3.786 ms) : 0, 3786
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (793.56 ms) : 0, 793560
BytebuddyAgent [candidate] (811.168 ms) : 0, 811168
GlobalTracer [baseline] (256.482 ms) : 0, 256482
GlobalTracer [candidate] (261.038 ms) : 0, 261038
IAST [baseline] (27.068 ms) : 0, 27068
IAST [candidate] (27.706 ms) : 0, 27706
AppSec [baseline] (34.554 ms) : 0, 34554
AppSec [candidate] (34.357 ms) : 0, 34357
Debugger [baseline] (64.866 ms) : 0, 64866
Debugger [candidate] (66.554 ms) : 0, 66554
Remote Config [baseline] (591.366 µs) : 0, 591
Remote Config [candidate] (630.824 µs) : 0, 631
Telemetry [baseline] (8.467 ms) : 0, 8467
Telemetry [candidate] (8.536 ms) : 0, 8536
Flare Poller [baseline] (3.657 ms) : 0, 3657
Flare Poller [candidate] (3.645 ms) : 0, 3645
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section baseline
no_agent (1.171 ms) : 1160, 1182
. : milestone, 1171,
iast (3.198 ms) : 3164, 3233
. : milestone, 3198,
iast_FULL (5.671 ms) : 5615, 5728
. : milestone, 5671,
iast_GLOBAL (3.464 ms) : 3420, 3508
. : milestone, 3464,
profiling (2.082 ms) : 2064, 2100
. : milestone, 2082,
tracing (1.764 ms) : 1750, 1779
. : milestone, 1764,
section candidate
no_agent (1.193 ms) : 1182, 1204
. : milestone, 1193,
iast (3.313 ms) : 3269, 3356
. : milestone, 3313,
iast_FULL (5.741 ms) : 5685, 5798
. : milestone, 5741,
iast_GLOBAL (3.743 ms) : 3673, 3813
. : milestone, 3743,
profiling (2.256 ms) : 2235, 2278
. : milestone, 2256,
tracing (1.796 ms) : 1781, 1811
. : milestone, 1796,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section baseline
no_agent (18.244 ms) : 18060, 18427
. : milestone, 18244,
appsec (18.773 ms) : 18583, 18962
. : milestone, 18773,
code_origins (17.734 ms) : 17558, 17910
. : milestone, 17734,
iast (17.511 ms) : 17336, 17685
. : milestone, 17511,
profiling (18.67 ms) : 18483, 18858
. : milestone, 18670,
tracing (17.599 ms) : 17425, 17773
. : milestone, 17599,
section candidate
no_agent (18.147 ms) : 17960, 18334
. : milestone, 18147,
appsec (18.881 ms) : 18690, 19072
. : milestone, 18881,
code_origins (17.774 ms) : 17597, 17951
. : milestone, 17774,
iast (17.736 ms) : 17556, 17916
. : milestone, 17736,
profiling (18.677 ms) : 18491, 18863
. : milestone, 18677,
tracing (17.777 ms) : 17600, 17953
. : milestone, 17777,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section baseline
no_agent (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
appsec (14.522 s) : 14522000, 14522000
. : milestone, 14522000,
iast (17.835 s) : 17835000, 17835000
. : milestone, 17835000,
iast_GLOBAL (17.827 s) : 17827000, 17827000
. : milestone, 17827000,
profiling (15.628 s) : 15628000, 15628000
. : milestone, 15628000,
tracing (14.502 s) : 14502000, 14502000
. : milestone, 14502000,
section candidate
no_agent (15.648 s) : 15648000, 15648000
. : milestone, 15648000,
appsec (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
iast (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
. : milestone, 17947000,
profiling (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
tracing (14.644 s) : 14644000, 14644000
. : milestone, 14644000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c154654eaa, baseline=1.59.0-SNAPSHOT~c154654eaa
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1486
. : milestone, 1474,
appsec (3.709 ms) : 3489, 3929
. : milestone, 3709,
iast (2.205 ms) : 2141, 2269
. : milestone, 2205,
iast_GLOBAL (2.265 ms) : 2199, 2330
. : milestone, 2265,
profiling (2.1 ms) : 2046, 2155
. : milestone, 2100,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.75 ms) : 3531, 3970
. : milestone, 3750,
iast (2.209 ms) : 2144, 2273
. : milestone, 2209,
iast_GLOBAL (2.262 ms) : 2196, 2327
. : milestone, 2262,
profiling (2.071 ms) : 2019, 2124
. : milestone, 2071,
tracing (2.059 ms) : 2008, 2110
. : milestone, 2059,
|
|
This was just an experiment to see AI could address the issue. As is, I cannot tell if this pull request solves the problem. |
PR by Bits
View Dev Agent Session
You can ask for changes by mentioning @DataDog in a comment.
Feedback (especially what can be better) welcome in #code-gen-feedback!
What Does This Do
NOTE: This is an experiment to see how Datadog CodeGen performs on integration issue
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-18237