Avoid final field mutation in UnsafeUtils#10476
Draft
sarahchen6 wants to merge 5 commits intomasterfrom
Draft
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 19 performance improvements and 7 performance regressions! Performance is the same for 39 metrics, 6 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060732
Total [baseline] (10.917 s) : 0, 10916726
Agent [candidate] (946.802 ms) : 0, 946802
Total [candidate] (10.373 s) : 0, 10373184
section appsec
Agent [baseline] (1.244 s) : 0, 1243614
Total [baseline] (11.037 s) : 0, 11036563
Agent [candidate] (1.121 s) : 0, 1120803
Total [candidate] (10.602 s) : 0, 10602370
section iast
Agent [baseline] (1.226 s) : 0, 1226019
Total [baseline] (11.213 s) : 0, 11212812
Agent [candidate] (1.112 s) : 0, 1111640
Total [candidate] (10.777 s) : 0, 10776693
section profiling
Agent [baseline] (1.186 s) : 0, 1185959
Total [baseline] (10.92 s) : 0, 10919726
Agent [candidate] (1.081 s) : 0, 1080705
Total [candidate] (10.569 s) : 0, 10569002
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (624.43 ms) : 0, 624430
BytebuddyAgent [candidate] (522.858 ms) : 0, 522858
AgentMeter [baseline] (28.762 ms) : 0, 28762
AgentMeter [candidate] (28.648 ms) : 0, 28648
GlobalTracer [baseline] (257.112 ms) : 0, 257112
GlobalTracer [candidate] (249.984 ms) : 0, 249984
AppSec [baseline] (32.677 ms) : 0, 32677
AppSec [candidate] (32.787 ms) : 0, 32787
Debugger [baseline] (60.347 ms) : 0, 60347
Debugger [candidate] (61.623 ms) : 0, 61623
Remote Config [baseline] (637.521 µs) : 0, 638
Remote Config [candidate] (630.822 µs) : 0, 631
Telemetry [baseline] (10.813 ms) : 0, 10813
Telemetry [candidate] (9.278 ms) : 0, 9278
Flare Poller [baseline] (9.212 ms) : 0, 9212
Flare Poller [candidate] (3.772 ms) : 0, 3772
section appsec
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (657.35 ms) : 0, 657350
BytebuddyAgent [candidate] (551.247 ms) : 0, 551247
AgentMeter [baseline] (11.969 ms) : 0, 11969
AgentMeter [candidate] (12.129 ms) : 0, 12129
GlobalTracer [baseline] (260.548 ms) : 0, 260548
GlobalTracer [candidate] (251.062 ms) : 0, 251062
IAST [baseline] (25.847 ms) : 0, 25847
IAST [candidate] (25.096 ms) : 0, 25096
AppSec [baseline] (168.77 ms) : 0, 168770
AppSec [candidate] (169.056 ms) : 0, 169056
Debugger [baseline] (68.532 ms) : 0, 68532
Debugger [candidate] (60.551 ms) : 0, 60551
Remote Config [baseline] (682.018 µs) : 0, 682
Remote Config [candidate] (666.101 µs) : 0, 666
Telemetry [baseline] (9.436 ms) : 0, 9436
Telemetry [candidate] (9.915 ms) : 0, 9915
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.78 ms) : 0, 3780
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (789.789 ms) : 0, 789789
BytebuddyAgent [candidate] (680.862 ms) : 0, 680862
AgentMeter [baseline] (11.204 ms) : 0, 11204
AgentMeter [candidate] (11.674 ms) : 0, 11674
GlobalTracer [baseline] (248.032 ms) : 0, 248032
GlobalTracer [candidate] (245.426 ms) : 0, 245426
IAST [baseline] (26.69 ms) : 0, 26690
IAST [candidate] (26.838 ms) : 0, 26838
AppSec [baseline] (34.465 ms) : 0, 34465
AppSec [candidate] (27.269 ms) : 0, 27269
Debugger [baseline] (66.446 ms) : 0, 66446
Debugger [candidate] (68.276 ms) : 0, 68276
Remote Config [baseline] (549.532 µs) : 0, 550
Remote Config [candidate] (548.897 µs) : 0, 549
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (10.008 ms) : 0, 10008
Flare Poller [baseline] (3.604 ms) : 0, 3604
Flare Poller [candidate] (3.568 ms) : 0, 3568
section profiling
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (676.56 ms) : 0, 676560
BytebuddyAgent [candidate] (569.278 ms) : 0, 569278
AgentMeter [baseline] (8.633 ms) : 0, 8633
AgentMeter [candidate] (8.803 ms) : 0, 8803
GlobalTracer [baseline] (216.613 ms) : 0, 216613
GlobalTracer [candidate] (217.666 ms) : 0, 217666
AppSec [baseline] (32.208 ms) : 0, 32208
AppSec [candidate] (33.263 ms) : 0, 33263
Debugger [baseline] (67.779 ms) : 0, 67779
Debugger [candidate] (60.655 ms) : 0, 60655
Remote Config [baseline] (595.001 µs) : 0, 595
Remote Config [candidate] (657.859 µs) : 0, 658
Telemetry [baseline] (8.855 ms) : 0, 8855
Telemetry [candidate] (9.002 ms) : 0, 9002
Flare Poller [baseline] (3.816 ms) : 0, 3816
Flare Poller [candidate] (3.717 ms) : 0, 3717
ProfilingAgent [baseline] (99.884 ms) : 0, 99884
ProfilingAgent [candidate] (105.958 ms) : 0, 105958
Profiling [baseline] (100.47 ms) : 0, 100470
Profiling [candidate] (106.545 ms) : 0, 106545
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066953
Total [baseline] (8.774 s) : 0, 8774477
Agent [candidate] (945.018 ms) : 0, 945018
Total [candidate] (8.725 s) : 0, 8725428
section iast
Agent [baseline] (1.231 s) : 0, 1231033
Total [baseline] (9.421 s) : 0, 9420744
Agent [candidate] (1.108 s) : 0, 1108440
Total [candidate] (9.392 s) : 0, 9391712
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (627.205 ms) : 0, 627205
BytebuddyAgent [candidate] (522.759 ms) : 0, 522759
AgentMeter [baseline] (28.982 ms) : 0, 28982
AgentMeter [candidate] (28.739 ms) : 0, 28739
GlobalTracer [baseline] (259.846 ms) : 0, 259846
GlobalTracer [candidate] (249.404 ms) : 0, 249404
AppSec [baseline] (33.22 ms) : 0, 33220
AppSec [candidate] (32.635 ms) : 0, 32635
Debugger [baseline] (63.214 ms) : 0, 63214
Debugger [candidate] (60.553 ms) : 0, 60553
Remote Config [baseline] (615.195 µs) : 0, 615
Remote Config [candidate] (631.519 µs) : 0, 632
Telemetry [baseline] (10.864 ms) : 0, 10864
Telemetry [candidate] (9.243 ms) : 0, 9243
Flare Poller [baseline] (6.098 ms) : 0, 6098
Flare Poller [candidate] (3.768 ms) : 0, 3768
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (795.495 ms) : 0, 795495
BytebuddyAgent [candidate] (679.116 ms) : 0, 679116
AgentMeter [baseline] (11.264 ms) : 0, 11264
AgentMeter [candidate] (11.655 ms) : 0, 11655
GlobalTracer [baseline] (248.469 ms) : 0, 248469
GlobalTracer [candidate] (245.143 ms) : 0, 245143
IAST [baseline] (26.826 ms) : 0, 26826
IAST [candidate] (26.762 ms) : 0, 26762
AppSec [baseline] (33.708 ms) : 0, 33708
AppSec [candidate] (27.16 ms) : 0, 27160
Debugger [baseline] (65.81 ms) : 0, 65810
Debugger [candidate] (67.099 ms) : 0, 67099
Remote Config [baseline] (557.358 µs) : 0, 557
Remote Config [candidate] (567.333 µs) : 0, 567
Telemetry [baseline] (8.686 ms) : 0, 8686
Telemetry [candidate] (10.332 ms) : 0, 10332
Flare Poller [baseline] (3.553 ms) : 0, 3553
Flare Poller [candidate] (3.553 ms) : 0, 3553
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (18.365 ms) : 18177, 18554
. : milestone, 18365,
appsec (18.773 ms) : 18585, 18960
. : milestone, 18773,
code_origins (17.724 ms) : 17548, 17901
. : milestone, 17724,
iast (17.672 ms) : 17494, 17849
. : milestone, 17672,
profiling (18.411 ms) : 18226, 18596
. : milestone, 18411,
tracing (17.816 ms) : 17635, 17997
. : milestone, 17816,
section candidate
no_agent (19.258 ms) : 19060, 19456
. : milestone, 19258,
appsec (18.539 ms) : 18353, 18726
. : milestone, 18539,
code_origins (17.872 ms) : 17692, 18052
. : milestone, 17872,
iast (18.817 ms) : 18627, 19007
. : milestone, 18817,
profiling (18.674 ms) : 18487, 18860
. : milestone, 18674,
tracing (17.615 ms) : 17442, 17788
. : milestone, 17615,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.223 ms) : 1212, 1235
. : milestone, 1223,
iast (3.203 ms) : 3161, 3244
. : milestone, 3203,
iast_FULL (5.847 ms) : 5787, 5906
. : milestone, 5847,
iast_GLOBAL (3.408 ms) : 3355, 3460
. : milestone, 3408,
profiling (2.208 ms) : 2187, 2229
. : milestone, 2208,
tracing (1.871 ms) : 1855, 1887
. : milestone, 1871,
section candidate
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.136 ms) : 3099, 3174
. : milestone, 3136,
iast_FULL (6.031 ms) : 5971, 6092
. : milestone, 6031,
iast_GLOBAL (3.487 ms) : 3428, 3547
. : milestone, 3487,
profiling (2.204 ms) : 2184, 2224
. : milestone, 2204,
tracing (1.864 ms) : 1847, 1880
. : milestone, 1864,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 3 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.773 ms) : 3552, 3994
. : milestone, 3773,
iast (2.262 ms) : 2193, 2332
. : milestone, 2262,
iast_GLOBAL (2.297 ms) : 2227, 2366
. : milestone, 2297,
profiling (2.09 ms) : 2034, 2145
. : milestone, 2090,
tracing (2.073 ms) : 2020, 2127
. : milestone, 2073,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.893 ms) : 3662, 4124
. : milestone, 3893,
iast (3.15 ms) : 2990, 3309
. : milestone, 3150,
iast_GLOBAL (3.267 ms) : 3103, 3432
. : milestone, 3267,
profiling (2.254 ms) : 2182, 2327
. : milestone, 2254,
tracing (2.194 ms) : 2128, 2261
. : milestone, 2194,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~83bde9a554, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
appsec (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
iast (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
iast_GLOBAL (17.562 s) : 17562000, 17562000
. : milestone, 17562000,
profiling (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
section candidate
no_agent (15.363 s) : 15363000, 15363000
. : milestone, 15363000,
appsec (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
iast (18.34 s) : 18340000, 18340000
. : milestone, 18340000,
iast_GLOBAL (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
profiling (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
tracing (15.122 s) : 15122000, 15122000
. : milestone, 15122000,
|
sarahchen6
commented
Feb 2, 2026
| def generalShadowJarConfig(ShadowJar shadowJarTask) { | ||
| shadowJarTask.with { | ||
| mergeServiceFiles() | ||
| zip64 = true |
Contributor
Author
There was a problem hiding this comment.
Needed to address org.apache.tools.zip.Zip64RequiredException: archive contains more than 65535 entries. (example failure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
When attempting to clone a final field using
UnsafeUtils::cloneFields, skip and instead emit a debug warning that final fields cannot be mutated. Update tests to reflect this as well.Motivation
Prepare for JEP 500 which disallows final field mutations.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-594