-
Notifications
You must be signed in to change notification settings - Fork 324
Caching the primaryInstrumentationName #10477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Caching the primaryInstrumentationName to avoid repeatedly calling instrumentationNames() and constantly allocating a String[]
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070838
Total [baseline] (8.714 s) : 0, 8713672
Agent [candidate] (1.067 s) : 0, 1066967
Total [candidate] (8.745 s) : 0, 8745189
section iast
Agent [baseline] (1.228 s) : 0, 1228454
Total [baseline] (9.349 s) : 0, 9348926
Agent [candidate] (1.242 s) : 0, 1241626
Total [candidate] (9.361 s) : 0, 9360531
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (631.86 ms) : 0, 631860
BytebuddyAgent [candidate] (629.728 ms) : 0, 629728
AgentMeter [baseline] (28.935 ms) : 0, 28935
AgentMeter [candidate] (28.66 ms) : 0, 28660
GlobalTracer [baseline] (258.715 ms) : 0, 258715
GlobalTracer [candidate] (257.924 ms) : 0, 257924
AppSec [baseline] (33.092 ms) : 0, 33092
AppSec [candidate] (32.938 ms) : 0, 32938
Debugger [baseline] (62.547 ms) : 0, 62547
Debugger [candidate] (60.517 ms) : 0, 60517
Remote Config [baseline] (623.304 µs) : 0, 623
Remote Config [candidate] (616.265 µs) : 0, 616
Telemetry [baseline] (13.028 ms) : 0, 13028
Telemetry [candidate] (15.409 ms) : 0, 15409
Flare Poller [baseline] (5.309 ms) : 0, 5309
Flare Poller [candidate] (4.667 ms) : 0, 4667
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (794.416 ms) : 0, 794416
BytebuddyAgent [candidate] (804.234 ms) : 0, 804234
AgentMeter [baseline] (11.143 ms) : 0, 11143
AgentMeter [candidate] (11.445 ms) : 0, 11445
GlobalTracer [baseline] (247.253 ms) : 0, 247253
GlobalTracer [candidate] (249.586 ms) : 0, 249586
IAST [baseline] (26.844 ms) : 0, 26844
IAST [candidate] (27.232 ms) : 0, 27232
AppSec [baseline] (32.295 ms) : 0, 32295
AppSec [candidate] (35.806 ms) : 0, 35806
Debugger [baseline] (67.546 ms) : 0, 67546
Debugger [candidate] (63.86 ms) : 0, 63860
Remote Config [baseline] (546.217 µs) : 0, 546
Remote Config [candidate] (541.235 µs) : 0, 541
Telemetry [baseline] (8.583 ms) : 0, 8583
Telemetry [candidate] (8.735 ms) : 0, 8735
Flare Poller [baseline] (3.389 ms) : 0, 3389
Flare Poller [candidate] (3.451 ms) : 0, 3451
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078974
Total [baseline] (10.965 s) : 0, 10965374
Agent [candidate] (1.072 s) : 0, 1071694
Total [candidate] (10.926 s) : 0, 10925655
section appsec
Agent [baseline] (1.239 s) : 0, 1239204
Total [baseline] (10.973 s) : 0, 10972501
Agent [candidate] (1.24 s) : 0, 1239514
Total [candidate] (11.01 s) : 0, 11009829
section iast
Agent [baseline] (1.233 s) : 0, 1232818
Total [baseline] (11.164 s) : 0, 11164308
Agent [candidate] (1.236 s) : 0, 1236111
Total [candidate] (11.14 s) : 0, 11140314
section profiling
Agent [baseline] (1.19 s) : 0, 1189624
Total [baseline] (10.985 s) : 0, 10985175
Agent [candidate] (1.189 s) : 0, 1188647
Total [candidate] (10.98 s) : 0, 10979545
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (637.722 ms) : 0, 637722
BytebuddyAgent [candidate] (632.689 ms) : 0, 632689
AgentMeter [baseline] (29.295 ms) : 0, 29295
AgentMeter [candidate] (29.025 ms) : 0, 29025
GlobalTracer [baseline] (261.347 ms) : 0, 261347
GlobalTracer [candidate] (259.394 ms) : 0, 259394
AppSec [baseline] (33.734 ms) : 0, 33734
AppSec [candidate] (33.091 ms) : 0, 33091
Debugger [baseline] (62.414 ms) : 0, 62414
Debugger [candidate] (62.388 ms) : 0, 62388
Remote Config [baseline] (634.009 µs) : 0, 634
Remote Config [candidate] (622.391 µs) : 0, 622
Telemetry [baseline] (11.612 ms) : 0, 11612
Telemetry [candidate] (12.416 ms) : 0, 12416
Flare Poller [baseline] (5.408 ms) : 0, 5408
Flare Poller [candidate] (5.397 ms) : 0, 5397
section appsec
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (658.548 ms) : 0, 658548
BytebuddyAgent [candidate] (658.16 ms) : 0, 658160
AgentMeter [baseline] (11.751 ms) : 0, 11751
AgentMeter [candidate] (11.775 ms) : 0, 11775
GlobalTracer [baseline] (258.297 ms) : 0, 258297
GlobalTracer [candidate] (258.805 ms) : 0, 258805
IAST [baseline] (25.204 ms) : 0, 25204
IAST [candidate] (25.27 ms) : 0, 25270
AppSec [baseline] (168.255 ms) : 0, 168255
AppSec [candidate] (167.826 ms) : 0, 167826
Debugger [baseline] (67.253 ms) : 0, 67253
Debugger [candidate] (67.524 ms) : 0, 67524
Remote Config [baseline] (689.03 µs) : 0, 689
Remote Config [candidate] (716.413 µs) : 0, 716
Telemetry [baseline] (9.116 ms) : 0, 9116
Telemetry [candidate] (9.251 ms) : 0, 9251
Flare Poller [baseline] (3.637 ms) : 0, 3637
Flare Poller [candidate] (3.729 ms) : 0, 3729
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (796.013 ms) : 0, 796013
BytebuddyAgent [candidate] (799.052 ms) : 0, 799052
AgentMeter [baseline] (11.146 ms) : 0, 11146
AgentMeter [candidate] (11.108 ms) : 0, 11108
GlobalTracer [baseline] (247.863 ms) : 0, 247863
GlobalTracer [candidate] (248.782 ms) : 0, 248782
IAST [baseline] (27.075 ms) : 0, 27075
IAST [candidate] (27.244 ms) : 0, 27244
AppSec [baseline] (34.21 ms) : 0, 34210
AppSec [candidate] (31.613 ms) : 0, 31613
Debugger [baseline] (67.278 ms) : 0, 67278
Debugger [candidate] (69.038 ms) : 0, 69038
Remote Config [baseline] (548.248 µs) : 0, 548
Remote Config [candidate] (560.648 µs) : 0, 561
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.7 ms) : 0, 8700
Flare Poller [baseline] (3.481 ms) : 0, 3481
Flare Poller [candidate] (3.485 ms) : 0, 3485
section profiling
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (680.981 ms) : 0, 680981
BytebuddyAgent [candidate] (680.732 ms) : 0, 680732
AgentMeter [baseline] (8.614 ms) : 0, 8614
AgentMeter [candidate] (8.574 ms) : 0, 8574
GlobalTracer [baseline] (216.05 ms) : 0, 216050
GlobalTracer [candidate] (215.752 ms) : 0, 215752
AppSec [baseline] (32.65 ms) : 0, 32650
AppSec [candidate] (32.371 ms) : 0, 32371
Debugger [baseline] (67.714 ms) : 0, 67714
Debugger [candidate] (67.432 ms) : 0, 67432
Remote Config [baseline] (595.462 µs) : 0, 595
Remote Config [candidate] (593.075 µs) : 0, 593
Telemetry [baseline] (8.816 ms) : 0, 8816
Telemetry [candidate] (8.724 ms) : 0, 8724
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.72 ms) : 0, 3720
ProfilingAgent [baseline] (99.495 ms) : 0, 99495
ProfilingAgent [candidate] (99.907 ms) : 0, 99907
Profiling [baseline] (100.068 ms) : 0, 100068
Profiling [candidate] (100.484 ms) : 0, 100484
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.101 ms) : 3064, 3139
. : milestone, 3101,
iast_FULL (5.906 ms) : 5846, 5966
. : milestone, 5906,
iast_GLOBAL (3.556 ms) : 3495, 3617
. : milestone, 3556,
profiling (2.1 ms) : 2081, 2120
. : milestone, 2100,
tracing (1.786 ms) : 1771, 1801
. : milestone, 1786,
section candidate
no_agent (1.187 ms) : 1175, 1198
. : milestone, 1187,
iast (3.171 ms) : 3127, 3215
. : milestone, 3171,
iast_FULL (5.972 ms) : 5911, 6034
. : milestone, 5972,
iast_GLOBAL (3.629 ms) : 3563, 3695
. : milestone, 3629,
profiling (2.222 ms) : 2202, 2243
. : milestone, 2222,
tracing (1.805 ms) : 1789, 1822
. : milestone, 1805,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (17.289 ms) : 17114, 17465
. : milestone, 17289,
appsec (18.875 ms) : 18686, 19064
. : milestone, 18875,
code_origins (18.485 ms) : 18298, 18672
. : milestone, 18485,
iast (17.58 ms) : 17404, 17756
. : milestone, 17580,
profiling (18.689 ms) : 18500, 18878
. : milestone, 18689,
tracing (17.761 ms) : 17586, 17936
. : milestone, 17761,
section candidate
no_agent (18.103 ms) : 17919, 18287
. : milestone, 18103,
appsec (19.835 ms) : 19632, 20039
. : milestone, 19835,
code_origins (17.467 ms) : 17289, 17644
. : milestone, 17467,
iast (17.498 ms) : 17326, 17670
. : milestone, 17498,
profiling (19.375 ms) : 19176, 19575
. : milestone, 19375,
tracing (17.833 ms) : 17657, 18010
. : milestone, 17833,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (3.765 ms) : 3543, 3987
. : milestone, 3765,
iast (2.25 ms) : 2181, 2319
. : milestone, 2250,
iast_GLOBAL (2.298 ms) : 2229, 2368
. : milestone, 2298,
profiling (2.073 ms) : 2019, 2128
. : milestone, 2073,
tracing (2.055 ms) : 2002, 2109
. : milestone, 2055,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.759 ms) : 3538, 3981
. : milestone, 3759,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.297 ms) : 2228, 2366
. : milestone, 2297,
profiling (2.089 ms) : 2033, 2145
. : milestone, 2089,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~f59123b30e, baseline=1.60.0-SNAPSHOT~4914aaefbc
dateFormat X
axisFormat %s
section baseline
no_agent (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
appsec (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
iast (18.156 s) : 18156000, 18156000
. : milestone, 18156000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
. : milestone, 18001000,
profiling (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
tracing (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
section candidate
no_agent (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
appsec (14.479 s) : 14479000, 14479000
. : milestone, 14479000,
iast (18.348 s) : 18348000, 18348000
. : milestone, 18348000,
iast_GLOBAL (18.28 s) : 18280000, 18280000
. : milestone, 18280000,
profiling (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
tracing (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
|
What Does This Do
Caching the primaryInstrumentationName to avoid repeatedly calling instrumentationNames and constantly allocating a String[]
Motivation
Avoid repetitive work and memory allocation
Additional Notes
The high load benchmarks are known to be flaky, but I wanted to double check the regressions anyway.
In a local load test, this change performed as expected...
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]