-
Notifications
You must be signed in to change notification settings - Fork 324
Improve git security settings #10486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - pass4sJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - reactive-streams-jvmJob Status: success
|
Test Environment - netflix-zuulJob Status: success
|
Test Environment - sonar-kotlinJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - okhttpJob Status: success
|
Test Environment - spring_bootJob Status: success
|
Test Environment - sonar-javaJob Status: success
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059183
Total [baseline] (10.955 s) : 0, 10955324
Agent [candidate] (1.058 s) : 0, 1057579
Total [candidate] (10.944 s) : 0, 10943624
section appsec
Agent [baseline] (1.235 s) : 0, 1234617
Total [baseline] (11.014 s) : 0, 11014016
Agent [candidate] (1.235 s) : 0, 1234616
Total [candidate] (11.042 s) : 0, 11041779
section iast
Agent [baseline] (1.228 s) : 0, 1228092
Total [baseline] (11.131 s) : 0, 11130607
Agent [candidate] (1.227 s) : 0, 1227103
Total [candidate] (11.211 s) : 0, 11211043
section profiling
Agent [baseline] (1.186 s) : 0, 1186467
Total [baseline] (10.904 s) : 0, 10903984
Agent [candidate] (1.187 s) : 0, 1186555
Total [candidate] (10.838 s) : 0, 10837578
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (623.351 ms) : 0, 623351
BytebuddyAgent [candidate] (622.667 ms) : 0, 622667
AgentMeter [baseline] (28.673 ms) : 0, 28673
AgentMeter [candidate] (28.642 ms) : 0, 28642
GlobalTracer [baseline] (257.629 ms) : 0, 257629
GlobalTracer [candidate] (257.097 ms) : 0, 257097
AppSec [baseline] (33.008 ms) : 0, 33008
AppSec [candidate] (32.824 ms) : 0, 32824
Debugger [baseline] (63.249 ms) : 0, 63249
Debugger [candidate] (61.639 ms) : 0, 61639
Remote Config [baseline] (615.962 µs) : 0, 616
Remote Config [candidate] (607.942 µs) : 0, 608
Telemetry [baseline] (9.197 ms) : 0, 9197
Telemetry [candidate] (11.455 ms) : 0, 11455
Flare Poller [baseline] (6.86 ms) : 0, 6860
Flare Poller [candidate] (6.018 ms) : 0, 6018
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (654.633 ms) : 0, 654633
BytebuddyAgent [candidate] (653.618 ms) : 0, 653618
AgentMeter [baseline] (11.863 ms) : 0, 11863
AgentMeter [candidate] (11.873 ms) : 0, 11873
GlobalTracer [baseline] (257.773 ms) : 0, 257773
GlobalTracer [candidate] (258.145 ms) : 0, 258145
IAST [baseline] (25.257 ms) : 0, 25257
IAST [candidate] (25.393 ms) : 0, 25393
AppSec [baseline] (167.044 ms) : 0, 167044
AppSec [candidate] (168.066 ms) : 0, 168066
Debugger [baseline] (67.804 ms) : 0, 67804
Debugger [candidate] (67.524 ms) : 0, 67524
Remote Config [baseline] (660.066 µs) : 0, 660
Remote Config [candidate] (648.834 µs) : 0, 649
Telemetry [baseline] (9.271 ms) : 0, 9271
Telemetry [candidate] (9.24 ms) : 0, 9240
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.588 ms) : 0, 3588
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (791.921 ms) : 0, 791921
BytebuddyAgent [candidate] (791.14 ms) : 0, 791140
AgentMeter [baseline] (11.165 ms) : 0, 11165
AgentMeter [candidate] (11.175 ms) : 0, 11175
GlobalTracer [baseline] (248.243 ms) : 0, 248243
GlobalTracer [candidate] (248.373 ms) : 0, 248373
IAST [baseline] (26.958 ms) : 0, 26958
IAST [candidate] (26.841 ms) : 0, 26841
AppSec [baseline] (32.045 ms) : 0, 32045
AppSec [candidate] (34.614 ms) : 0, 34614
Debugger [baseline] (68.442 ms) : 0, 68442
Debugger [candidate] (65.861 ms) : 0, 65861
Remote Config [baseline] (545.683 µs) : 0, 546
Remote Config [candidate] (550.754 µs) : 0, 551
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (8.511 ms) : 0, 8511
Flare Poller [baseline] (3.518 ms) : 0, 3518
Flare Poller [candidate] (3.491 ms) : 0, 3491
section profiling
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (677.207 ms) : 0, 677207
BytebuddyAgent [candidate] (678.201 ms) : 0, 678201
AgentMeter [baseline] (8.629 ms) : 0, 8629
AgentMeter [candidate] (8.623 ms) : 0, 8623
GlobalTracer [baseline] (217.453 ms) : 0, 217453
GlobalTracer [candidate] (216.894 ms) : 0, 216894
AppSec [baseline] (32.379 ms) : 0, 32379
AppSec [candidate] (32.284 ms) : 0, 32284
Debugger [baseline] (67.936 ms) : 0, 67936
Debugger [candidate] (67.726 ms) : 0, 67726
Remote Config [baseline] (607.513 µs) : 0, 608
Remote Config [candidate] (595.93 µs) : 0, 596
Telemetry [baseline] (8.746 ms) : 0, 8746
Telemetry [candidate] (8.652 ms) : 0, 8652
Flare Poller [baseline] (3.712 ms) : 0, 3712
Flare Poller [candidate] (3.737 ms) : 0, 3737
ProfilingAgent [baseline] (98.804 ms) : 0, 98804
ProfilingAgent [candidate] (98.754 ms) : 0, 98754
Profiling [baseline] (99.381 ms) : 0, 99381
Profiling [candidate] (99.318 ms) : 0, 99318
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054952
Total [baseline] (8.7 s) : 0, 8700386
Agent [candidate] (1.06 s) : 0, 1059899
Total [candidate] (8.759 s) : 0, 8758662
section iast
Agent [baseline] (1.238 s) : 0, 1238064
Total [baseline] (9.429 s) : 0, 9428896
Agent [candidate] (1.234 s) : 0, 1234417
Total [candidate] (9.41 s) : 0, 9409799
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (622.7 ms) : 0, 622700
BytebuddyAgent [candidate] (624.633 ms) : 0, 624633
AgentMeter [baseline] (28.641 ms) : 0, 28641
AgentMeter [candidate] (28.709 ms) : 0, 28709
GlobalTracer [baseline] (256.497 ms) : 0, 256497
GlobalTracer [candidate] (257.689 ms) : 0, 257689
AppSec [baseline] (32.699 ms) : 0, 32699
AppSec [candidate] (32.793 ms) : 0, 32793
Debugger [baseline] (61.093 ms) : 0, 61093
Debugger [candidate] (61.697 ms) : 0, 61697
Remote Config [baseline] (617.986 µs) : 0, 618
Remote Config [candidate] (624.428 µs) : 0, 624
Telemetry [baseline] (9.172 ms) : 0, 9172
Telemetry [candidate] (9.231 ms) : 0, 9231
Flare Poller [baseline] (6.928 ms) : 0, 6928
Flare Poller [candidate] (7.871 ms) : 0, 7871
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (799.477 ms) : 0, 799477
BytebuddyAgent [candidate] (797.059 ms) : 0, 797059
AgentMeter [baseline] (11.442 ms) : 0, 11442
AgentMeter [candidate] (11.266 ms) : 0, 11266
GlobalTracer [baseline] (250.476 ms) : 0, 250476
GlobalTracer [candidate] (249.835 ms) : 0, 249835
IAST [baseline] (27.147 ms) : 0, 27147
IAST [candidate] (27.033 ms) : 0, 27033
AppSec [baseline] (33.007 ms) : 0, 33007
AppSec [candidate] (33.893 ms) : 0, 33893
Debugger [baseline] (67.083 ms) : 0, 67083
Debugger [candidate] (65.953 ms) : 0, 65953
Remote Config [baseline] (559.822 µs) : 0, 560
Remote Config [candidate] (551.187 µs) : 0, 551
Telemetry [baseline] (8.635 ms) : 0, 8635
Telemetry [candidate] (8.536 ms) : 0, 8536
Flare Poller [baseline] (3.54 ms) : 0, 3540
Flare Poller [candidate] (3.524 ms) : 0, 3524
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section baseline
no_agent (17.948 ms) : 17766, 18129
. : milestone, 17948,
appsec (18.399 ms) : 18212, 18586
. : milestone, 18399,
code_origins (17.748 ms) : 17572, 17923
. : milestone, 17748,
iast (17.403 ms) : 17233, 17574
. : milestone, 17403,
profiling (18.48 ms) : 18298, 18661
. : milestone, 18480,
tracing (17.859 ms) : 17681, 18038
. : milestone, 17859,
section candidate
no_agent (18.195 ms) : 18010, 18381
. : milestone, 18195,
appsec (18.345 ms) : 18158, 18531
. : milestone, 18345,
code_origins (17.803 ms) : 17627, 17979
. : milestone, 17803,
iast (17.508 ms) : 17335, 17680
. : milestone, 17508,
profiling (19.059 ms) : 18867, 19251
. : milestone, 19059,
tracing (17.749 ms) : 17574, 17924
. : milestone, 17749,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1172, 1195
. : milestone, 1183,
iast (3.164 ms) : 3124, 3204
. : milestone, 3164,
iast_FULL (5.898 ms) : 5838, 5958
. : milestone, 5898,
iast_GLOBAL (3.535 ms) : 3478, 3591
. : milestone, 3535,
profiling (2.182 ms) : 2161, 2204
. : milestone, 2182,
tracing (1.786 ms) : 1771, 1800
. : milestone, 1786,
section candidate
no_agent (1.181 ms) : 1169, 1193
. : milestone, 1181,
iast (3.161 ms) : 3119, 3204
. : milestone, 3161,
iast_FULL (5.995 ms) : 5935, 6056
. : milestone, 5995,
iast_GLOBAL (3.475 ms) : 3425, 3525
. : milestone, 3475,
profiling (1.94 ms) : 1924, 1957
. : milestone, 1940,
tracing (1.795 ms) : 1780, 1810
. : milestone, 1795,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section baseline
no_agent (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
appsec (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
iast (18.492 s) : 18492000, 18492000
. : milestone, 18492000,
iast_GLOBAL (17.793 s) : 17793000, 17793000
. : milestone, 17793000,
profiling (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
tracing (14.642 s) : 14642000, 14642000
. : milestone, 14642000,
section candidate
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
iast (18.107 s) : 18107000, 18107000
. : milestone, 18107000,
iast_GLOBAL (17.662 s) : 17662000, 17662000
. : milestone, 17662000,
profiling (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
tracing (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~b59fa697e4, baseline=1.59.0-SNAPSHOT~67d83b3d5a
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.707 ms) : 3487, 3927
. : milestone, 3707,
iast (2.269 ms) : 2200, 2338
. : milestone, 2269,
iast_GLOBAL (2.316 ms) : 2246, 2386
. : milestone, 2316,
profiling (2.091 ms) : 2037, 2146
. : milestone, 2091,
tracing (2.067 ms) : 2014, 2121
. : milestone, 2067,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.7 ms) : 3484, 3916
. : milestone, 3700,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.309 ms) : 2240, 2378
. : milestone, 2309,
profiling (2.092 ms) : 2037, 2146
. : milestone, 2092,
tracing (2.076 ms) : 2023, 2129
. : milestone, 2076,
|
What Does This Do
-c safe.directory=...as config in all git commands instead of adding it withgit config --global --add safe.directory ....gitdirectory or file.Motivation
The previous approach, to avoid "dubious ownership" errors, actually added a new global git config option every single time that code run, causing config pollution.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-3224