Enhance MySQLManager with additional database operations#110
Open
sauramel wants to merge 1 commit intoDataPupOrg:mainfrom
Open
Enhance MySQLManager with additional database operations#110sauramel wants to merge 1 commit intoDataPupOrg:mainfrom
sauramel wants to merge 1 commit intoDataPupOrg:mainfrom
Conversation
- Introduced methods for inserting, updating, and deleting rows in the MySQLManager class. - Updated connection handling to store original configuration and track readonly connections. - Improved error handling for database operations to ensure proper connection checks. - Adjusted SQL queries to use qualified table names based on the current database context. - Modified default database selection in DatabaseConnection component for MySQL connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Complete MySQL/MariaDB Support
Summary
Description
This PR implements complete MySQL/MariaDB support for DataPup, bringing the database client to feature parity with existing ClickHouse and PostgreSQL implementations. The MySQL manager now includes all required CRUD operations, proper connection management, schema introspection, and transaction support. Users can now connect to MySQL/MariaDB databases and perform all standard database operations including querying, inserting, updating, and deleting data.
Type of Change
Please mark the relevant option(s):
Related Issues
Fixes # (MySQL/MariaDB support implementation)
Screenshots/Recordings
Before
MySQL was listed as "Coming Soon" in documentation and had incomplete implementation
After
MySQL now appears in supported database types and connects successfully
Testing
Please confirm the following:
Test Instructions
npm run devSELECT 1to verify query executionAdditional Notes
This PR completes the MySQL/MariaDB implementation that was previously marked as "coming soon" in the project documentation. The implementation follows the same architectural patterns as the existing ClickHouse and PostgreSQL managers, ensuring consistency and maintainability. All methods now return proper TypeScript interface types instead of
any, improving type safety throughout the codebase.The changes include:
Checklist