Open
Conversation
…pace and ActiveConnectionLayout
- Added CacheManager to manage caching of query results. - Introduced QueryCache for storing cached results with eviction policies. - Implemented QueryNormalizer to standardize SQL queries for consistent caching. - Updated BaseDatabaseManager to utilize caching in query execution. - Enhanced ClickHouseManager to handle caching with specific configurations. - Added IPC handlers for cache management in the main process. - Created CacheMonitor component for monitoring cache statistics and configuration in the UI. - Added types for cache entries, metadata, configuration, and statistics.
- Fix boolean type inference issue with regex match results - Explicitly check for null to ensure proper boolean return type
864d6be to
bfc3a9f
Compare
Contributor
|
This will only save on network round trip and the queries we run to populate the tables in the left pane. We should probably not do this because, if a user runs a INSERT statement followed by a SELECT. he would not be seeing the latest insertion @Krishnachaitanyakc thoughts? |
Collaborator
Author
|
Good point, let me tweak the implementation to invalidate cache when we perform a write operation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queries
operations
- Enhanced generateCacheKey() with conditional session logic
- Session-independent queries: ${connectionId}:${database}
- Session-dependent queries: ${connectionId}:${database}:${sessionId}
- Updated methods to accept optional sessionId parameter
- Added comprehensive logging for cache strategy monitoring
- Enhanced metadata tracking with isSessionIndependent field
- Updated BaseDatabaseManager.query() to pass sessionId to cache methods
- ClickHouse-specific cache optimizations with longer TTL and compression
- Maintained backward compatibility with existing cache invalidation
- Detailed cache hit/store logging with strategy information
- TypeScript error fixes for proper type inference
- Performance tracking for cache strategy effectiveness