cleanup: remove createTranslator methods in BaseTest#65
cleanup: remove createTranslator methods in BaseTest#65timazhum wants to merge 1 commit intoDeepLcom:mainfrom
Conversation
Addressing TODO of removing createTranslator() methods in BaseTest and using createDeepLClient() instead
|
@JanEbbing @daniel-jones-dev a tiny-tiny clean up for the tests, based on |
|
Thanks for this. I'm a tiny bit hesitant, because now if I ever accidentally make a backwards incompatible change to E: Alternatively, we could just release 2.0 and get rid of |
Sounds fair, didn’t know Translate still had a roadmap for deprecation. I’d leave the whole test suite until 2.0 and put this pull request on hold |
|
Your PR definitely makes sense. I'll discuss in the team how soon we want to switch to 2.0 across this library and others due to the |
Addressing TODO of removing createTranslator() methods in BaseTest and using createDeepLClient() instead