Calendar: Fix Overview demo TypeError in isHoliday function#32029
Merged
r-farkhutdinov merged 1 commit intoDevExpress:25_2from Feb 13, 2026
Merged
Calendar: Fix Overview demo TypeError in isHoliday function#32029r-farkhutdinov merged 1 commit intoDevExpress:25_2from
r-farkhutdinov merged 1 commit intoDevExpress:25_2from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError in the Calendar Overview demo's jQuery implementation. The isHoliday function was incorrectly attempting to access a date property on a Date object parameter, when it should directly call Date methods on the parameter itself.
- Corrects the
isHolidayfunction to call Date methods directly on the parameter (d.getDate()instead ofd.date.getDate())
r-farkhutdinov
force-pushed
the
25_2_calendar_demo_fix
branch
from
eeeda6f to
8a1e425
Compare
marker-dao
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.