Skip to content

Storybook: Add manual deployment workflow#32356

Merged
chaosmirage merged 6 commits intoDevExpress:26_1from
r-farkhutdinov:26_1_storybook_preview_manual
Feb 2, 2026
Merged

Storybook: Add manual deployment workflow#32356
chaosmirage merged 6 commits intoDevExpress:26_1from
r-farkhutdinov:26_1_storybook_preview_manual

Conversation

@r-farkhutdinov
Copy link
Contributor

No description provided.

@r-farkhutdinov r-farkhutdinov self-assigned this Jan 30, 2026
@r-farkhutdinov r-farkhutdinov force-pushed the 26_1_storybook_preview_manual branch from d7562e6 to 8e5ee48 Compare February 2, 2026 11:51
@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review February 2, 2026 13:30
@r-farkhutdinov r-farkhutdinov requested a review from a team as a code owner February 2, 2026 13:30
Copilot AI review requested due to automatic review settings February 2, 2026 13:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new manual GitHub Actions workflow for deploying Storybook PR previews. The workflow allows maintainers to manually trigger deployment or removal of Storybook previews for specific pull requests using GitHub Pages.

Changes:

  • Adds workflow_dispatch trigger for manual deployment of Storybook previews to GitHub Pages
  • Implements conditional build steps that only execute for "deploy" action
  • Uses pr-preview-action to manage preview deployments on gh-pages branch

Ruslan Farkhutdinov added 2 commits February 2, 2026 15:42
Copilot AI review requested due to automatic review settings February 2, 2026 13:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

if: inputs.action == 'deploy'
run: |
pnpm nx build devextreme-react-storybook

Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the action is 'remove', all setup steps are skipped (lines 38-81), but the deployment step at line 83 still runs. The pr-preview-action needs to checkout the gh-pages branch and remove the preview directory when action is 'remove'.

However, without the checkout step running (line 38 has if: inputs.action == 'deploy'), the action may not have access to the repository. Consider adding a separate checkout step for the 'remove' action that checks out the default branch or gh-pages branch, or removing the condition from line 38 so checkout always happens.

Suggested change
- name: Checkout gh-pages for removal
if: inputs.action == 'remove'
uses: actions/checkout@v4
with:
ref: gh-pages
fetch-depth: 1

Copilot uses AI. Check for mistakes.
@chaosmirage chaosmirage merged commit 3534be7 into DevExpress:26_1 Feb 2, 2026
105 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants