Multi-level Navbar Menu #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
This looks good. Just a couple of extra things:
I'll review it formally after you get the tests created. |
JamesDoingStuff
force-pushed
the
jg/multilevel-menu
branch
4 times, most recently
from
88ca5c4 to
9f75851
Compare
Closed
Closed
Collaborator
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
Looks good and you've handles accessibility well. Just a couple of minor points.
JamesDoingStuff
force-pushed
the
jg/multilevel-menu
branch
from
9f75851 to
dda2f86
Compare
Member
|
@JamesDoingStuff @VictoriaBeilsten-Edmands Any update on this? |
Collaborator
Author
|
I've just noticed that I accidentally committed a bunch of auto-formatting to the changelog, so I'll get rid of that now, but otherwise I think I've made all the suggested changes - just needs approval |
JamesDoingStuff
force-pushed
the
jg/multilevel-menu
branch
from
1b5e1e9 to
83c2d0d
Compare
akademy
force-pushed
the
jg/multilevel-menu
branch
from
cfe3555 to
1193ca2
Compare
akademy
force-pushed
the
jg/multilevel-menu
branch
from
1193ca2 to
3cbd5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #52
Couple of things worth mentioning:
fireEventwas too restrictive)NavMenuLinkto work with focus I had to use ref forwarding, and to support router links without duplicating code, it now uses theNavLink, but this meant adding ref forwarding toNavLinkas well, lest the console fill up with React warnings.