[0.17] MODIFIED: blockheaders include block height, nodes validate it#442
Closed
jtimon wants to merge 4 commits intoElementsProject:elements-0.17from
Closed
[0.17] MODIFIED: blockheaders include block height, nodes validate it#442jtimon wants to merge 4 commits intoElementsProject:elements-0.17from
jtimon wants to merge 4 commits intoElementsProject:elements-0.17from
Conversation
jtimon
force-pushed
the
e17-competing-431
branch
from
cf08bbd to
f00e979
Compare
Contributor
|
closing as redundant, thanks for the fixups |
Contributor
Author
|
It isn't fully redundant since this version includes an extra test: f00e979#diff-912bf7afc60ccdf9de453ce3a8e0ffceR29 but perhaps #436 is not wanted for some reason. |
Contributor
|
#436 is still in flight, good catch on test. I was trying to avoid stacking PRs when not necessary and missed it, mentioned on the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Competing version of #431
Waiting for @instagibbs 's review before squashing.
Includes #436 which allows to add a small test for this as suggested in #431 (comment)