Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Made it so all keyboard inputs are cancelled when the mouse pointer is unlocked.
There was an issue where if you were holding keys down then unlocked the cursor by pressing the ESC key, those keys would get stuck as held down despite not being held down.
Overall this is the best fix I could think of, the program can't tell that the Escape key specifically was pressed while pointer lock is active and I believe that behaviour is hardcoded into javascript.
Since some projects may already have their own workarounds without cancelling all keyboard inputs, I'm changing the version number from 0.3.0 to 1.0.0
(Also updated the icon to be more self-explanatory)
How to use the new features
Hold a key down then press esc to see the key doesn't get stuck as held down anymore.
Checklist
Example file
game.zip
Extension file
MousePointerLock.zip
Extension by @Peeblo-r
You can update the extension on this "Pull Request" by commenting the update command: in the comment field, type
!update, then drag and drop a zip file with your extension file in the commenting field, like how you initially submitted the extension. It should look like this:It can take a few seconds for the file to fully upload and show as the above. Once it is like shown above, click "Comment" and let the bot do the rest!