Skip to content

Conversation

@arnautov-anton
Copy link
Contributor

🎯 Goal

Use the capabilities of WithComponents to propagate component overrides, do not use Channel as a proxy.

BREAKING CHANGE: Channel component no longer supports component overrides, use WithComponents instead.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Size Change: 0 B

Total Size: 316 kB

ℹ️ View Unchanged
Filename Size
./dist/audioProcessing-BbOs2wMd.js 1.32 kB
./dist/Channel-nqbkMa9b.js 23.3 kB
./dist/cjs/emojis.js 3.84 kB
./dist/cjs/experimental.js 5.82 kB
./dist/cjs/index.js 174 kB
./dist/cjs/mp3-encoder.js 1.27 kB
./dist/css/emojis.css 113 B
./dist/css/index.css 23 kB
./dist/css/v2/emoji-mart.css 1.84 kB
./dist/css/v2/emoji-replacement.css 300 B
./dist/css/v2/index.css 39.4 kB
./dist/css/v2/index.layout.css 22.8 kB
./dist/useIsCooldownActive-CxZum4Vt.js 522 B
./dist/useMessageReminder-Cf7RkEP_.js 18.3 kB

compressed-size-action

Copy link
Member

@oliverlaz oliverlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to adjust the docs too

@arnautov-anton
Copy link
Contributor Author

Good to adjust the docs too

Yes, that's the next step as discussed earlier. :)

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.97%. Comparing base (73f8767) to head (8a04000).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2904      +/-   ##
==========================================
- Coverage   80.05%   79.97%   -0.08%     
==========================================
  Files         511      511              
  Lines       10803    10802       -1     
  Branches     2711     2711              
==========================================
- Hits         8648     8639       -9     
- Misses       1902     1910       +8     
  Partials      253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

<ChatView.Selector />
<ChatView.Channels>
<ChannelList
Avatar={ChannelAvatar}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnautov-anton don't we want to apply the same logic to ChannelList? I mean to not to allow passing Components as props and force the use of WithComponents.

Copy link
Contributor Author

@arnautov-anton arnautov-anton Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I can adjust the PR to include ChannelList too.

Edit: I'll open up separate PR to include renames to the ChannelList-related components.

@arnautov-anton arnautov-anton force-pushed the fix/remove-channel-component-propagation branch 2 times, most recently from 0387026 to 9f8b99d Compare January 22, 2026 11:25
@arnautov-anton arnautov-anton force-pushed the fix/remove-channel-component-propagation branch 2 times, most recently from 8a04000 to 79568f3 Compare February 3, 2026 09:39
@arnautov-anton arnautov-anton force-pushed the fix/remove-channel-component-propagation branch from 79568f3 to 4dc6419 Compare February 3, 2026 09:45
@arnautov-anton arnautov-anton merged commit cd6001f into master Feb 3, 2026
4 of 5 checks passed
@arnautov-anton arnautov-anton deleted the fix/remove-channel-component-propagation branch February 3, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants