Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
… layout updates - Add ChannelHeader styling folder (SCSS) per dev-patterns - Reorder layout: icon | text block | avatar (right) - Add sidebarCollapsed prop with IconLayoutAlignLeft when collapsed - Add IconLayoutAlignLeft to Icons - Add aria/Expand sidebar translations to all locales Co-authored-by: Cursor <cursoragent@cursor.com>
- Render FloatingDateSeparator
- Add NewMessageNotification as standalone component at bottom of message list
- Style NewMessageNotification per Figma (pill, design tokens)
- Remove MessageNotification from MessageListNotifications; simplify props to { notifications }
- Move isNotAtLatestMessageSet visibility logic into ScrollToLatestMessageButton
- Rename ScrollToBottomButton to ScrollToLatestMessageButton
- Replace ComponentContext.MessageNotification with NewMessageNotification
- Remove "Latest Messages" string and related i18n entries
# Conflicts: # src/components/MessageList/styling/MessageList.scss
Co-authored-by: Cursor <cursoragent@cursor.com>
…nsumers Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # src/components/Badge/Badge.tsx # src/components/MessageList/ScrollToLatestMessageButton.tsx # src/components/MessageList/UnreadMessagesNotification.tsx # src/components/MessageList/UnreadMessagesSeparator.tsx # src/components/MessageList/VirtualizedMessageList.tsx # src/components/MessageList/styling/ScrollToLatestMessageButton.scss
MartinCupela
requested review from
arnautov-anton and
oliverlaz
as code owners
|
Size Change: +874 B (+0.21%) Total Size: 408 kB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes REACT-721: Add new ChannelHeader
BREAKING CHANGE: remove support for "live" label
BREAKING CHANGE: remove support for displaying channel.data.subtitle under the title
BREAKING CHANGE: replace str-chat__channel-header-end with str-chat__channel-header__data
🛠 Implementation details
The sidebar toggle button on the left has as a click handle
openMobileNav. I always disliked very very much this limiting approach of thinking that the only purpose of this button is toggle some mobile nav - too specific. However, in this PR I focus only on the redesign. I am already putting together a view controller API proposal that would be provided throughChatViewcomponents and consumed also inChannelHeader. It would be customizable, what this button actually does.🎨 UI Changes