Replace use of deprecated class BoundedDict with BoundedAttributes#238
Replace use of deprecated class BoundedDict with BoundedAttributes#238shevisj wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shevisj
force-pushed
the
patch-1
branch
2 times, most recently
from
56d2389 to
f803ccf
Compare
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
LGTM thank you for your contribution!
|
/gcbrun |
|
I'm fixing the CI in #239 |
|
/gcbrun |
Head branch was pushed to by a user without write access
|
Hmm, unfortunately it looks like the BoundedAttributes class has tighter constraints on allowed attribute value types as compared with BoundedDict. I will work on getting my local dev env configured so that I can play around with it and can get tests to pass locally. |
Head branch was pushed to by a user without write access
shevisj
force-pushed
the
patch-1
branch
2 times, most recently
from
859b3ba to
4a18808
Compare
…m version requirement for opentelemetry-api to 1.4 for opentelemetry-exporter-gcp-trace
|
/gcbrun |
|
@shevisj do you have any idea how to fix the issue or could update this PR? |
2 participants
Replace deprecated BoundedDict with BoundedAttributes and bump minimum version requirement of
opentelemetry-apifrom 1.0 to 1.4 inopentelemetry-exporter-gcp-traceFixes #226