fix: deleteFromCacheByFields to mirror logic from findByFields#95
Open
bentburton wants to merge 1 commit intoGraphQLGuide:masterfrom
Open
fix: deleteFromCacheByFields to mirror logic from findByFields#95bentburton wants to merge 1 commit intoGraphQLGuide:masterfrom
bentburton wants to merge 1 commit intoGraphQLGuide:masterfrom
Conversation
lorensr
requested changes
May 15, 2022
Member
lorensr
left a comment
lorensr
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can you add a test that covers the current bug in main?
| const fieldNames = Object.keys(cleanedFields) | ||
|
|
||
| loader.clear(loaderKey) | ||
| // match logic from findByFields |
Member
There was a problem hiding this comment.
Can you put duplicated logic in a helper function, for better maintainability?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently deleteFromCacheByFields doesn't follow the same logic as findByFields for the loader key. This leads to incorrect behavior when the cache is supposed to be invalidated from a call to deleteFromCacheByFields but findByFields keeps returning the stale result because of the loader field mismatch.