Skip to content

Fix Text node/tool max width/height bounding box calculation#3628

Merged
Keavon merged 4 commits intoGraphiteEditor:masterfrom
jsjgdh:new_branch2
Feb 14, 2026
Merged

Fix Text node/tool max width/height bounding box calculation#3628
Keavon merged 4 commits intoGraphiteEditor:masterfrom
jsjgdh:new_branch2

Conversation

@jsjgdh
Copy link
Contributor

@jsjgdh jsjgdh commented Jan 12, 2026

This PR fixes a bug in which the text bound box didn't work as intended when only one of Max Width or Max Height were set. The box would wrongly clamp to the text's rendered size instead of the specified maximum dimension. Fixes #3626.

before :-
Screenshot 2026-01-12 212044

Now:-
Screenshot 2026-01-12 212220

@Keavon
Copy link
Member

Keavon commented Jan 13, 2026

!build

@github-actions
Copy link

📦 Build Complete for 4a06fed
https://42dbd169.graphite.pages.dev

@jsjgdh jsjgdh force-pushed the new_branch2 branch 3 times, most recently from 70d6241 to f18250a Compare February 3, 2026 07:33
@Keavon Keavon changed the title Fix: correctly applied max width/height in text bounding box Fix Text node/tool max width/height bounding box calculation Feb 14, 2026
@Keavon Keavon enabled auto-merge (squash) February 14, 2026 18:54
@Keavon Keavon disabled auto-merge February 14, 2026 19:11
@Keavon Keavon enabled auto-merge (squash) February 14, 2026 21:01
@Keavon Keavon merged commit 84f91eb into GraphiteEditor:master Feb 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The box area of text is displayed wrong if EITHER max width or max height is active, but works if both are

2 participants