Fix duplicate shared upstream nodes when duplicating layers#3654
Open
afrdbaig7 wants to merge 1 commit intoGraphiteEditor:masterfrom
Open
Fix duplicate shared upstream nodes when duplicating layers#3654afrdbaig7 wants to merge 1 commit intoGraphiteEditor:masterfrom
afrdbaig7 wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where duplicating multiple layers that share the same input Text node would create multiple duplicate Text nodes instead of reusing a single one. The problem occurred because shared upstream nodes added during traversal weren’t being tracked, allowing the same node to be collected more than once. The fix ensures each upstream node is handled only once while preserving the existing traversal order, so duplicating shared layer chains now behaves as expected.
Fixes #2501.