Rename nodes from "Instance ___" -> "Read ___" and "Instance Map" -> "Map Vector"

[Keavon]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Keavon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors and renames several nodes within the node graph system to improve clarity and organization. Nodes that read information from the evaluation context, such as index and position, have been renamed from 'Instance ___' to 'Read ___' and moved into a dedicated context module. Additionally, the 'Instance Map' node has been renamed to 'Map Vector' to more accurately describe its operation on vectors. These changes streamline the node naming conventions and centralize context-related functionalities.

Highlights

• Node Renaming: Renamed nodes from the 'Instance ___' pattern to 'Read ___' (e.g., 'Instance Index' to 'Read Index', 'Instance Vector' to 'Read Vector', 'Instance Position' to 'Read Position').
• Node Renaming: Renamed 'Instance Map' to 'Map Vector' to better reflect its functionality.
• Module Restructuring: Moved context-reading nodes (Read Index, Read Position, Read Vector) into a new dedicated context module within gcore.
• Migration Updates: Updated document node definitions and migration logic to correctly reference the newly named and relocated nodes.

Changelog

• editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs
  • Updated references from 'Instance Index' to 'Read Index'.
  • Updated references from 'Instance Vector' to 'Read Vector'.
  • Updated references from 'Instance Map' to 'Map Vector'.
• editor/src/messages/portfolio/document_migration.rs
  • Modified NodeReplacement entries for Instance Index, Instance Map, Instance Position, and Instance Vector to point to their new identifiers and added new aliases.
  • Updated migration logic to use the new read_index and read_position identifiers.
• node-graph/nodes/gcore/src/context.rs
  • Added read_vector node, previously instance_vector.
  • Added read_position node, previously instance_position.
  • Added read_index node, previously instance_index.
• node-graph/nodes/gcore/src/lib.rs
  • Declared and re-exported the new context module.
• node-graph/nodes/gstd/src/lib.rs
  • Integrated the new context module and adjusted top-level re-exports.
• node-graph/nodes/vector/src/instance.rs
  • Removed instance_position and instance_index node implementations, as they were moved to the context module.
  • Removed ExtractIndex and ExtractPosition from core_types imports.
• node-graph/nodes/vector/src/vector_nodes.rs
  • Removed instance_vector node implementation.
  • Renamed instance_map to map_vector.
  • Removed ExtractVarArgs from core_types imports.

Activity

• No specific activity (comments, reviews, progress updates) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly renames several nodes from Instance ___ to Read ___ and Instance Map to Map Vector, and moves the Read ___ nodes to a new context module. The changes are consistent and well-executed across the codebase, including documentation, node definitions, and migration logic.

I've added a few suggestions to improve code clarity and fix a minor inconsistency in the migration script. Overall, this is a solid refactoring that improves the naming and organization of these nodes.