修复语言为文言时下载游戏的选择模组加载器页面的版本号未本地化的问题#5359
Merged
Glavo merged 4 commits intoHMCL-dev:mainfrom Feb 26, 2026
Hidden character warning
The head ref may contain hidden characters: "\u566b\u5401\u56b1"
Merged
Conversation
Glavo
reviewed
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the localization of version numbers when the language is set to Classical Chinese (文言). The version numbers displayed on the mod loader selection page during game download were not being properly translated.
Changes:
- Added localization for game version numbers in the mod loader list view
- Added localization for installer version numbers in the installers page
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| VersionsPage.java | Applied I18n localization to game version numbers displayed as tags/subtitles for mod loaders (Forge, Fabric, etc.) |
| InstallersPage.java | Applied I18n localization to mod loader version numbers displayed in the installers page |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
reviewed
Feb 5, 2026
| @Override | ||
| public String getTitle() { | ||
| return group.getGame().versionProperty().get().version(); | ||
| return ((RemoteVersion) controller.getSettings().get("game")).getGameVersion(); |
Member
There was a problem hiding this comment.
原本页面标题中的游戏版本号是本地化的，你这样修改让标题不再是本地化的。
Contributor
Author
There was a problem hiding this comment.
这是用在实例名字和实例名输入框的，我们不希望它被本地化成如一點二一點一一-neoforge的形式https://github.com/HMCL-dev/HMCL/pull/5359/changes#r2741429594
private void setTxtNameWithLoaders() {
StringBuilder nameBuilder = new StringBuilder(getTitle());
}
Glavo
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复后
修复前