Logging Section Migration#450
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-450 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-450 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-450 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-450 This preview will update automatically when you push new commits. |
kriszyp
left a comment
There was a problem hiding this comment.
This looks great! Just a few comments. I don't know that they necessarily need to be addressed.
|
|
||
| Type: `boolean` | ||
|
|
||
| Default: `false` |
There was a problem hiding this comment.
This is correct (I know AI felt unsure). However, we do default this to true in Fabric: https://github.com/HarperFast/host-manager/blob/main/src/templates/compose.yaml#L64
(not sure if this should be mentioned here)
There was a problem hiding this comment.
Not worth mentioning the difference on Fabric. I think it is important to treat this reference as what comes "out of the box" from our core package (i.e. npm i harperdb)
| auditLog: false | ||
| ``` | ||
|
|
||
| ### `logging.auditRetention` |
There was a problem hiding this comment.
I will note that we did move the audit operations into a separate operation (because audit/transaction log is totally different than app logging), but we still have in here. However, I think it would be too contrived to try to have this in a different config section, so I think we should leave this as is.
(And we should consider migrating transaction/audit log to a different configuration section).
There was a problem hiding this comment.
Yeah I noticed that too. I think its good to think about for future v5 and beyond changes.
|
|
||
| ```typescript | ||
| interface MainLogger { | ||
| trace(message: any, ...args: any[]): void; |
There was a problem hiding this comment.
All the arguments are basically treated the same (the actual implementation uses warn(...args)); does this adequately communicate this?
There was a problem hiding this comment.
I guess technically we support no args right now and this typing doesn't explicitly make that clear. I can fix it.
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
Logging Section Migration
Summary
Migration of Logging documentation from
versioned_docs/into the new v4 consolidated reference structure.Files Created
reference_versioned_docs/version-v4/logging/overview.mdreference_versioned_docs/version-v4/logging/configuration.mdreference_versioned_docs/version-v4/logging/api.mdreference_versioned_docs/version-v4/logging/operations.mdSource Files Used
logging/overview.mdversioned_docs/version-4.7/administration/logging/index.md(primary)versioned_docs/version-4.7/administration/logging/standard-logging.md(log format, levels, threads, stdStreams, rotation)release-notes/v4-tucker/4.1.0.md(confirmed logging consolidated into hdb.log)release-notes/v4-tucker/4.6.0.md(confirmed per-component logging, Node.js Console API basis)logging/configuration.mdversioned_docs/version-4.7/deployments/configuration.md(logging section, lines 858–1065, primary)versioned_docs/version-4.7/administration/logging/standard-logging.md(rotation, stdStreams, clustering)release-notes/v4-tucker/4.2.0.md(confirmed auditAuthEvents.logFailed/logSuccessful added)release-notes/v4-tucker/4.6.0.md(confirmed per-component logging, dynamic reload, HTTP logging)logging/api.mdversioned_docs/version-4.7/reference/globals.md(logger global, primary)versioned_docs/version-4.7/administration/logging/standard-logging.md(context)release-notes/v4-tucker/4.6.0.md(confirmed Node.js Console API basis)logging/operations.mdversioned_docs/version-4.7/developers/operations-api/logs.md(primary —read_logoperation)versioned_docs/version-4.7/administration/logging/standard-logging.md(context)Version Annotations Added
High Confidence (Confirmed via release notes)
hdb.log: v4.1.0auditAuthEvents.logFailed/logSuccessful: v4.2.0logging.external, etc.): v4.6.0Needs Verification
loggerglobal availability: Listed as available since v4.1.0 (when components were introduced) but the Node.js Console API basis was confirmed in v4.6.0. The exact version theloggerglobal was first available may need verification.Scope Decision
Audit logging and transaction logging operations (
read_audit_log,read_transaction_log,delete_audit_logs_before,delete_transaction_logs_before) are not included here — they belong in the Database / Transaction Logging section as planned. Thelogging/operations.mdpage covers onlyread_log(standard Harper log). Thelogging/configuration.mdpage coverslogging.auditLog: true/falsebut redirects readers to the database section for audit log details.Link Placeholders Created
See
migration-context/link-placeholders/logging-link-placeholders.mdfor complete list.Summary:
database/transaction.mdconfiguration/overview.mdhttp/configuration.md(already exists — can be resolved now)operations-api/overview.mdImages/Assets Noted
None — Logging docs contain no images.
Conflicts & Questions for Human Review
Content Notes
logging.leveldefault: The configuration docs saywarn, but the standard-logging.md page sayserror("We try to keep logging to a minimum by default, to do this the default log level iserror"). The configuration docs are more authoritative and recent — usingwarn. Human reviewer should confirm.logging.consoledefault: Listed astruein the section header description but the 4.6.0 release notes say "console logging does not get logged to the log files by default." Usedfalseas the default. Human reviewer should verify.Migration Map Status
Updated all four logging pages to "In Progress"
Checklist for Human Reviewer
logging.leveldefault (warnvserror— conflicting in source)logging.consoledefault (truevsfalse— conflicting signals)loggerglobal was first availablehttp/configuration.mdlink placeholder (file already exists)🤖 Generated with Claude Code