Skip to content

changed notification length 100->150 #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voxvargr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

changed notification length 100->150 #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97fa830
Update NotificationManager.h
voxvargr Feb 15, 2026
0897fa1
Create ci
voxvargr Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
workflow_dispatch: # <--- Add this line
Copy link
Contributor

@minacode minacode Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this better be a separate PR?

Copy link
Author

@voxvargr voxvargr Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have no idea, I'm still learning how GitHub even works I just wanted to share my modification in case anyone wanted it.

2 changes: 1 addition & 1 deletion src/components/ble/NotificationManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace Pinetime {
HighProriotyAlert,
InstantMessage
};
static constexpr uint8_t MessageSize {100};
static constexpr uint8_t MessageSize {150};

struct Notification {
using Id = uint8_t;
Expand Down