[MAINT] Use std::size_t from cstddef and use dpctl::tensor::ssize_t where ssize_t is used

[ndgrigorian]

This PR changes the reliance of dpctl headers on size_t being translated by the compiler by instead including cstddef and replacing size_t with std::size_t throughout.

Additionally, using dpctl::tensor::ssize_t is used wherever ssize_t comes up.

• Have you provided a meaningful PR description?
• Have you added a test, reproducer or referred to an issue with a reproducer?
• Have you tested your changes locally for CPU and GPU devices?
• Have you made sure that new changes do not introduce compiler warnings?
• Have you checked performance impact of proposed changes?
• Have you added documentation for your changes, if necessary?
• Have you added your changes to the changelog?
• If this PR is a work in progress, are you opening the PR as a draft?

[github-actions]

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_358 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[oleksandr-pavlyk]

@ndgrigorian Looks like these two instances were missed:

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpctl$ grep -r size_t dpctl/tensor/libtensor/ | grep -v "std::size_t" | grep -v "ssize_t" | grep -v "size_to"
dpctl/tensor/libtensor/include/kernels/elementwise_functions/trunc.hpp:                              size_t nelems,
dpctl/tensor/libtensor/include/kernels/elementwise_functions/trunc.hpp:                   size_t nelems,

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_359 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[ndgrigorian]

@ndgrigorian Looks like these two instances were missed:

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/dpctl$ grep -r size_t dpctl/tensor/libtensor/ | grep -v "std::size_t" | grep -v "ssize_t" | grep -v "size_to"
dpctl/tensor/libtensor/include/kernels/elementwise_functions/trunc.hpp:                              size_t nelems,
dpctl/tensor/libtensor/include/kernels/elementwise_functions/trunc.hpp:                   size_t nelems,

I've pushed a change fixing these, good catch!

[oleksandr-pavlyk]

@ndgrigorian These changes look good to me. I think it is ready for review and ready to be merged in.

One thing to check is whether changes here might conflict with changes in feature/topk branch

[ndgrigorian]

@ndgrigorian These changes look good to me. I think it is ready for review and ready to be merged in.

One thing to check is whether changes here might conflict with changes in feature/topk branch

I'll go ahead and check if they do. I will also have to rebase onto master and check for more instances with the accumulator improvement PR merged.

[oleksandr-pavlyk]

The coverage workflow failed with 8 ctest failures related to sycl::kernel_bundle and sycl::kernel

[oleksandr-pavlyk]

The reason for failures is the std::size_t should not he used in declarations and definitions of EXTERN "C" functions due to name mangling

[oleksandr-pavlyk]

The C compatible type is defined in "stddef.h"

[ndgrigorian]

The reason for failures is the std::size_t should not he used in declarations and definitions of EXTERN "C" functions due to name mangling

Uses in libsyclinterface have been removed

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_366 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_366 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

[coveralls]

coverage: 87.716%. remained the same
when pulling 919d772 on use-std-size-t-cstddef
into 3a1a7c5 on master.

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_367 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

[ndgrigorian]

@ndgrigorian These changes look good to me. I think it is ready for review and ready to be merged in.

One thing to check is whether changes here might conflict with changes in feature/topk branch

Unfortunately there are conflicts in merge_sort.hpp and radix_sort.hpp

It may be best to merge this after topk

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_370 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_369 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[ndgrigorian]

@oleksandr-pavlyk
I've also reverted use of std::size_t in _host_task_utils.hpp

In the process, I've also noticed that we are using py::ssize_t as the type for the number of elements in an array for get_size method and in size Python equivalent, while throughout libtensor Python bindings, we use size_t to represent the number of elements.

This inconsistency can be resolved in a later PR, but we should probably use size_t everywhere for this.

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_369 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_400 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[ndgrigorian]

@oleksandr-pavlyk
topk is merged and conflicts with this branch and master are resolved

[oleksandr-pavlyk]

Thank you @ndgrigorian ! Look good to go in

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_406 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

[oleksandr-pavlyk]

The GH rules require an approval from somebody other than the author of the last commit.

Please add a change to changelog to work around that issue

[ndgrigorian]

The GH rules require an approval from somebody other than the author of the last commit.

Please add a change to changelog to work around that issue

Added to the changelog

[github-actions]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_407 ran successfully.
Passed: 894
Failed: 2
Skipped: 118